364969 - Keyboard tab bar navigation broken

Status: RESOLVED DUPLICATE of bug 363934

(SeaMonkey :: UI Design, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Open multiple tabs
2. Focus one tab (in the tab bar)
3. Try to use the left/right arrow keys to switch between the tabs.

This only works one time, nothing happens when trying further.
This is the SeaMonkey version of Bug 363934, caused by Bug 330705. Regression range matches, the fix from toolkit/ can probably be used for xpfe/, too.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Same patch as in Bug 363934, just for xpfe/.

Comment 2

[Frank Wein [:mcsmurf]]

Comment on attachment 249627 [details] [diff] [review]
Patch

This patch causes issues, namely "Error: document.commandDispatcher.focusedElement has no properties
Source File: chrome://global/content/bindings/tabbrowser.xml
Line: 710" sometimes occurs in the JS Console and so "breaks" the tab browser.

Comment 3

[Martijn Wargers (dead)]

Oops, sorry, the patch should use document.commandDispatcher.focusedElement instead of this.mCurrentBrowser.focusedElement.

Comment 4

[[e-mail]]

Comment on attachment 249627 [details] [diff] [review]
Patch

Maybe if (hadFocus && this.mCurrentBrowser.focusedElement) {

Comment 5

[Martijn Wargers (dead)]

(In reply to comment #4)
> (From update of attachment 249627 [details] [diff] [review])
> Maybe if (hadFocus && this.mCurrentBrowser.focusedElement) {

I tried that (saveFocus), but that doesn't seem to fix the bug.

Comment 6

[[e-mail]]

(In reply to comment #5)
>(In reply to comment #4)
>>(From update of attachment 249627 [details] [diff] [review])
>>Maybe if (hadFocus && this.mCurrentBrowser.focusedElement) {
>I tried that (saveFocus), but that doesn't seem to fix the bug.
Sorry, hadFocus was something left over from another patch that I was writing.

Comment 7

[Martijn Wargers (dead)]

Sorry, this should be fixed now with the patch from bug 363934.