365003 - Crash [@ DocumentViewerImpl::SetBounds] with testcase that sets print preview while iframe window resizes

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase, which crashes within 1 second.
The testcase uses enhanced privileges, so you need to load it from your local computer to get the crash.

This regressed between 2006-12-09 and 2006-12-10:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-12-09+03&maxdate=2006-12-10+06&cvsroot=%2Fcvsroot
The only relevant patch in that range seems to be from bug 361844.


Talkback ID: TB27739268M
DocumentViewerImpl::SetBounds  [mozilla\layout\base\nsdocumentviewer.cpp, line 1877]
nsSubDocumentFrame::Reflow  [mozilla\layout\generic\nsframeframe.cpp, line 455]
nsLineLayout::ReflowFrame  [mozilla\layout\generic\nslinelayout.cpp, line 818]

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Martijn Wargers (dead)]

Attachment: testcase

Comment 3

[Mats Palmgren (inactive)]

Attachment: stack

Comment 4

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

The crash occurs when we access nsPrintEngine data while it's still
being created (mIsCreatingPrintPreview = 1, see stack) such as SetBounds
does in this case.
I considered making DocumentViewerImpl::GetIsPrintPreview() check this
flag and return false if it was set, but I don't think that would be
right for most of the calls to GetIsPrintPreview(). So I added checks
only where I think they are needed.

Comment 5

[Eli Friedman]

Comment on attachment 249699 [details] [diff] [review]
Patch rev. 1

Looks good to me.

Comment 6

[Mats Palmgren (inactive)]

Checked in to trunk at 2007-01-01 02:53 PST

-> FIXED

Comment 7

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070103 Minefield/3.0a2pre