[Mac Classic] menus in menulists should have same margin as menuitems

RESOLVED FIXED in seamonkey1.1final

Status

SeaMonkey
General
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

({fixed-seamonkey1.1.1})

Trunk
seamonkey1.1final
PowerPC
Mac OS X
fixed-seamonkey1.1.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Spin-off from bug 364620. The effect of not having the same styling is that if you have an icon in a menulist menu, the icon is too far at the right compared with the surrounding menuitem icons. Pinstripe doesn't have the issue, but I somehow forget to add it to classic.
(Assignee)

Comment 1

11 years ago
JFTR: Pinstripe styles: toolkit/themes/pinstripe/global/menu.css#180 etc
(Assignee)

Comment 2

11 years ago
Created attachment 249718 [details] [diff] [review]
Fix menus in menulists

This will fix the issue with menus in menulists. If you have a menu in a menulist with an icon, the icon does not line up with the label text anymore (same behaviour as menuitems). Not sure if it's too late for 1.1...
Assignee: general → stefanh
Status: NEW → ASSIGNED
Attachment #249718 - Flags: superreview?(neil)
Attachment #249718 - Flags: review?(mnyromyr)
Attachment #249718 - Flags: approval-seamonkey1.1?

Comment 3

11 years ago
Any chance of a before/after screenshot?
(Assignee)

Comment 4

11 years ago
Created attachment 249782 [details]
Before/after screenshot

Here's a screenshot. Note that I wouldn't mind having the icons left margin align with the left margin of the menuitem labels. But (iirc) that would affect the checkmarks as well - and they should not be aligned with the labels. So, this was a compromise when I did the native styling. What I did was that I forgot the menus, though. Note also that I have never seen any icon in a "real" mac menulist. Ideally, I would like one widget for menuitems with checkmarks and one other for menuitems with icons - now they use the same menu-iconic one.

Updated

11 years ago
Attachment #249718 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 5

10 years ago
Comment on attachment 249718 [details] [diff] [review]
Fix menus in menulists

Removing obsolete request...
Attachment #249718 - Flags: approval-seamonkey1.1?

Updated

10 years ago
Attachment #249718 - Flags: review?(mnyromyr) → review+
(Assignee)

Updated

10 years ago
Attachment #249718 - Flags: approval-seamonkey1.1.1?
(Assignee)

Comment 6

10 years ago
Karsten, can you check this in on trunk, please? Some baking is always good.
Comment on attachment 249718 [details] [diff] [review]
Fix menus in menulists

first-a=me, need one more

Comment 8

10 years ago
Landed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 9

10 years ago
Comment on attachment 249718 [details] [diff] [review]
Fix menus in menulists

a=me for 1.1.1
Attachment #249718 - Flags: approval-seamonkey1.1.1? → approval-seamonkey1.1.1+

Comment 10

10 years ago
Landed on MOZILLA_1_8_BRANCH.

Updated

10 years ago
Keywords: fixed-seamonkey1.1.1
You need to log in before you can comment on or make changes to this bug.