365039 - [Mac Classic] menus in menulists should have same margin as menuitems

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Stefan [:stefanh]]

Spin-off from bug 364620. The effect of not having the same styling is that if you have an icon in a menulist menu, the icon is too far at the right compared with the surrounding menuitem icons. Pinstripe doesn't have the issue, but I somehow forget to add it to classic.

Comment 1

[Stefan [:stefanh]]

JFTR: Pinstripe styles: toolkit/themes/pinstripe/global/menu.css#180 etc

Comment 2

[Stefan [:stefanh]]

Attachment: Fix menus in menulists

This will fix the issue with menus in menulists. If you have a menu in a menulist with an icon, the icon does not line up with the label text anymore (same behaviour as menuitems). Not sure if it's too late for 1.1...

Comment 3

[[e-mail]]

Any chance of a before/after screenshot?

Comment 4

[Stefan [:stefanh]]

Attachment: Before/after screenshot

Here's a screenshot. Note that I wouldn't mind having the icons left margin align with the left margin of the menuitem labels. But (iirc) that would affect the checkmarks as well - and they should not be aligned with the labels. So, this was a compromise when I did the native styling. What I did was that I forgot the menus, though. Note also that I have never seen any icon in a "real" mac menulist. Ideally, I would like one widget for menuitems with checkmarks and one other for menuitems with icons - now they use the same menu-iconic one.

Comment 5

[Stefan [:stefanh]]

Comment on attachment 249718 [details] [diff] [review]
Fix menus in menulists

Removing obsolete request...

Comment 6

[Stefan [:stefanh]]

Karsten, can you check this in on trunk, please? Some baking is always good.

Comment 7

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 249718 [details] [diff] [review]
Fix menus in menulists

first-a=me, need one more

Comment 8

[Karsten Düsterloh]

Landed on trunk.

Comment 9

[Robert Kaiser]

Comment on attachment 249718 [details] [diff] [review]
Fix menus in menulists

a=me for 1.1.1

Comment 10

[Karsten Düsterloh]

Landed on MOZILLA_1_8_BRANCH.