365082 - QuickSearch using unknown field makes Bugzilla hang

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P4)

Description

[Jesse Ruderman]

Bugzilla never gives me results for https://bugzilla.mozilla.org/buglist.cgi?quicksearch=foo%3Abar.  I'm guessing it's either trying to return all the bugs in bmo or it hit an infinite loop.

Comment 1

[Frédéric Buclin]

Marc, could you have a look? foo:bar should either be ignored, or be seen as "foo:bar" (in which case it shouldn't be slower than any other request).

Comment 2

[Jesse Ruderman]

When QuickSearch was client-side, foo:bar was treated as an error.  I think that behavior is better, because you get useful feedback if you typo or mis-abbreviate a field name.

Comment 3

[Teemu Mannermaa (:wicked)]

Indeed, unknown fields are now ignored so that quicksearch will try to fetch all open bugs. We should change this back to throwing an error but allow quoting to be used to make it normal search word. This way |foo:bar| will throw an error but |"foo:bar"| will do normal quicksearch for the foo:bar word.

Comment 4

[Frédéric Buclin]

I wonder if shadow DB replication may lag behind due to this bug.

Comment 5

[Max Kanat-Alexander]

Not a blocker, but something we should fix for 3.0 or 3.0.1. I haven't seen significant DB lag--quicksearch only reads, it doesn't write. (So it shouldn't prevent replication.)

Comment 6

[Teemu Mannermaa (:wicked)]

Attachment: Throw user error, V1

This changes logic back to throw an user error if there are any unknown fields. Quoting can already be used to make such words normal search words.

Comment 7

[Frédéric Buclin]

Comment on attachment 272970 [details] [diff] [review]
Throw user error, V1

>Index: Bugzilla/Search/Quicksearch.pm

>+        if (scalar(@unknownFields) > 0) {

Nit: |> 0| is optional.



>Index: template/en/default/global/user-error.html.tmpl

>+    [% IF fields.unique.size == 1 %]
>+    Field <code>[% fields.first FILTER html %]</code> is not a known field.
>+    [% ELSE %]

Nit: indentation!


>+    The legal field names are <a href="page.cgi?id=quicksearchhack.html">are
>+    listed here</a>.

Nit: 'are' appears twice in the sentence. The one enclosed in the link should be removed.


Your patch is working fine on both 3.0 and 3.1, and the nits can be fixed on checkin. r=LpSolit

Comment 8

[Frédéric Buclin]

tip:

Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.17; previous revision: 1.16
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.218; previous revision: 1.217
done


3.0:

Checking in Bugzilla/Search/Quicksearch.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Search/Quicksearch.pm,v  <--  Quicksearch.pm
new revision: 1.12.2.2; previous revision: 1.12.2.1
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.204.2.4; previous revision: 1.204.2.3
done