365092 - Inactive flag types should be excluded from the JS array in the bug creation form

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Bernd]

and takes very long to load

Comment 1

[timeless]

for reference:

https://bugzilla.mozilla.org/editflagtypes.cgi?action=edit&id=39
blocking1.3a Use this flag to nominate bugs for fixing in the 1.3alpha milestone. If the bug is deemed critical for the release by [e-mail] it will receive a "+". If the bug is deemed to not be critical for this release drivers will add a "-" to the flag.  1    Copy | Delete

So, it's including disabled flags -- and we have lots of them.

Comment 2

[Frédéric Buclin]

The problem is about the flag_list array in JS. It takes 90+% of the total page size.

Comment 3

[Jesse Ruderman]

The bulk of the Enter Bug page is a per-component lists of which flags apply to
the component.  Easy fixes:

(1) figure out why the flag list for each component is 20 times as long as it
should be and fix that.  (It is including disabled/obsolete flags?)

(2) Convert the flag lists to array literals like "foo = [39, 43, ...]" instead
of "foo[0] = 39", "foo[1] = 43", ...

If that's not enough:

(3) Add a list of flags that applies to all of the components, to get rid of
redundancy.

And if it's *still* too long (which I think is unlikely), it may need to be
AJAXified.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1 (exclude inactive flag types)

Inactive flag types cannot be set nor requested on bug creation, so let's exclude them.

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 249750 [details] [diff] [review]
patch, v1 (exclude inactive flag types)

per test on bugzilla-test, lpsolit says "it's not quite right"

Comment 6

[Frédéric Buclin]

Attachment: patch, v2 (exclude inactive flag types)

We don't specify the size of the JS array when creating it as it will depends on the number of inactive flag types.

Comment 7

[Frédéric Buclin]

For the record:

With my patch applied, enter_bug.cgi's size decreases from 834 Kb to 169 Kb, and each component now has only 13 (active) flags instead of 154.

Comment 8

[Olav Vitters]

Attachment: Patch v3

Partially use array literals as well. (stuff like: flags[0] = [3,5,2,4,6];). Even better would be to make one big flags in one go, but I think this provides most of the saving while still being easy to follow.

Note: the source used to be like:
flags[0] = ["3","5","2","4","6"];

However, those quotes are not needed (AFAIK).

Comment 9

[Frédéric Buclin]

Comment on attachment 249754 [details] [diff] [review]
Patch v3

>+      [% flag_list.push("$f.id") %]

Nit: you can write .push(f.id) directly. No need to add quotes.


>+    flags[[% count %]] = [[% flag_list.join(",") %]];

t/008filter....NOK 165
#   Failed test '(en/default) template/en/default/bug/create/create.html.tmpl has unfiltered directives:
#   62: flag_list.join(",")
# --ERROR'

FILTER html or FILTER none will be fine here.


I will attach an updated patch with both comments fixed. Nice work, bkor. r=LpSolit

Comment 10

[Frédéric Buclin]

Attachment: patch, v3.1

Fixing filterexceptions.pl as well. I realized meanwhile that JS code needs to use FILTER js.

Comment 11

[Frédéric Buclin]

Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.93; previous revision: 1.92
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.74; previous revision: 1.73
done

Comment 12

[Frédéric Buclin]

(In reply to comment #7)
> With my patch applied, enter_bug.cgi's size decreases from 834 Kb to 169 Kb,

With the v3.1 patch, this page is now 113 Kb.