365229 - email_in.pl modifies bug permissions without user entering fields

Status: RESOLVED FIXED

(Bugzilla :: Incoming Email, defect)

Description

[Bill Barry]

when modifying a bug using the inbound email interface the following occurs without any user intervention:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      CC Accessible|1                           |0
Reporter Accessible|1                           |0

This seems to happen when the two checkboxes are checked and then you modify the bug through the email.

I used a simple "email" to modify the bug:
From: [e-mail]
Subject: [Bug 7150]

Here is a simple change that causes the bug to occur.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Hey Bill, could you tell me if this fixes it for you?

Comment 2

[Bill Barry]

(I would review- that, but I am unauthorized to do so)

With that patch I seem to get an error sending email and the bug doesn't get modified.

Here is the error I get:
Use of uninitialized value in pattern match (m//) at Bugzilla/Mailer.pm line 87, <STDIN> line 8.
There was an error sending mail from '@systems-300.stellarfinancial.com'
    to '<[e-mail]>':Can't call method "address" on an undefined value at /usr/lib/perl5/site_perl/5.8.8/Email/Send/SMTP.pm line 56, <STDIN> line 8.

Does this make any sense?

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> There was an error sending mail from '@systems-300.stellarfinancial.com'
>     to '<[e-mail]>':Can't call method "address" on an

  That means that there was an error in *sending you an error*. So there was some real error, but we can't see it. Could you attach the output of email_in.pl -vvv with that same email in?

Comment 4

[Bill Barry]

Parsed Fields:
$VAR1 = {
          'comment' => 'exaustive error reporting for page
----------
28500 committed by bbarry

U   current/storefront/trunk/StoreFront/Auth.aspx.cs
',
          'bug_id' => '7084',
          'reporter' => '[e-mail]'
        };

Updating Bug 7084...
Use of uninitialized value in pattern match (m//) at Bugzilla/Mailer.pm line 87, <STDIN> line 8.
There was an error sending mail from '@systems-300.stellarfinancial.com'
    to '<[e-mail]>':Can't call method "address" on an undefined value at /usr/lib/perl5/site_perl/5.8.8/Email/Send/SMTP.pm line 56, <STDIN> line 8.

Comment 5

[Bill Barry]

How would I fix the error of it not sending me an error?
-vvv still gives it.

Comment 6

[Bill Barry]

after adding the following to your patch (in the process subroutine):
@@ -231,11 +233,13 @@
         $fields{'addtonewgroup'} = 0;
     }

+debug_print("beginning process fields foreach");
     foreach my $field (REQUIRED_PROCESS_FIELDS) {
         my $value = $bug->$field;
         if (ref $value) {
             $value = join(',', @$value);
         }
+debug_print("Found value $value for $field");
         $fields{$field} ||= $value;
     }


I get the following when I attempt to do this:
[#####@systems-300 bugzilla]# ./email_in.pl -vvvv <bugtry.txt
Parsing Email
Body:
this is a test of a mozilla patch

Parsed Fields:
$VAR1 = {
          'comment' => 'this is a test of a mozilla patch
',
          'bug_id' => '7063',
          'reporter' => '[e-mail]'
        };

Updating Bug 7063...
beginning process fields foreach
Found value  for dependson
Found value  for blocked
Found value unspecified for version
Found value Deleted for product
Found value --- for target_milestone
Found value Other for rep_platform
Found value Other for op_sys
Found value P3 for priority
Found value normal for bug_severity
Found value  for bug_file_loc
Found value untitled for component
Found value testing flags for short_desc
Found value 1 for reporter_accessible
Use of uninitialized value in pattern match (m//) at Bugzilla/Mailer.pm line 87, <STDIN> line 4.
There was an error sending mail from '@systems-300.stellarfinancial.com'
   to '<[e-mail]>':Can't call method "address" on an undefined value at /usr/lib/perl5/site_perl/5.8.8/Email/Send/SMTP.pm line 56, <STDIN> line 4


It looks as if it is failing on the cc_accessible line.
... runs off to test theory ...

Sure enough if I remove the cc_accessible line, it works. Is that the name of the field?

Comment 7

[Bill Barry]

change it from cc_accessible to cclist_accessible and it works

Comment 8

[Max Kanat-Alexander]

Comment on attachment 249960 [details] [diff] [review]
v1

Ah, okay. I'll fix that. :-)

Comment 9

[Max Kanat-Alexander]

Attachment: v2

Okay, from what Bill says, this works and is a trivial change.

Comment 10

[Frédéric Buclin]

Comment on attachment 250389 [details] [diff] [review]
v2

Looks good. r=LpSolit

Comment 11

[Max Kanat-Alexander]

Checking in email_in.pl;
/cvsroot/mozilla/webtools/bugzilla/email_in.pl,v  <--  email_in.pl
new revision: 1.4; previous revision: 1.3
done