365300 - [mod_perl] Editing a saved search does not re-populate the search page

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

When I attempt to edit any of my saved searches (click "Edit Search" in the line-above-the-footer-table after running the search), instead of getting a Search page with all the parameters and values of my saved search pre-filled, I get a Search page which only has ";bug_file_loc_type" in the URL input :/

Trying to edit the search from the "Saved Searches" section of the Preferences results in the same failure.

Comment 1

[Dave Miller [:justdave]]

This is specific to running under mod_perl....  this showed up after we enabled mod_perl tonight.  No clue why.....

Comment 2

[Dave Miller [:justdave]]

see also bug 365293 - probably related.

Comment 3

[Dave Miller [:justdave]]

I've deactivated mod_perl on production for the time being until we figure this out, this is too big a deal to leave it broken.  mod_perl is once again active on bugzilla-test to give us somewhere to play.

Comment 4

[Dave Miller [:justdave]]

OK, more information: this problem only exhibits itself in the combination of mod_perl and SSL.  mod_perl on a cleartext http site works fine, without mod_perl on an https site works fine, mod_perl on an https site causes this problem.  Just gets weirder and weirder.

Comment 5

[Wayne Mery (:wsmwk)]

Search page, after "edit search" from a buglist/search results, has same symptoms as comment 0 - values lost plus URL input contains ;bug_file_loc_type

Comment 6

[Frédéric Buclin]

Attachment: patch, v1

This works on a non-mod_perl installation.

Comment 7

[Frédéric Buclin]

Attachment: patch, v1.1

There was a missing $foundone = 1 in my previous patch, and so in some cases the query was overwritten by the default query.

Comment 8

[Frédéric Buclin]

OK, this seems to fix the problem on bugzilla-test, with mod_perl enabled.

Comment 9

[Dave Miller [:justdave]]

Comment on attachment 249920 [details] [diff] [review]
patch, v1.1

Yep, and as weird as it sounds, this appears to fix bug 365293 as well.

Comment 10

[Dave Miller [:justdave]]

For those following along, the PrefillForm() function was trying to decode the query string manually...  and presumably we're doing something wrong.  This patch changes it to use Perl's CGI module to do the decoding for us (we already do everywhere else in Bugzilla), which apparently knows how to deal with whatever edge case we're hitting in the CGI operation.

Comment 11

[Frédéric Buclin]

Checking in query.cgi;
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v  <--  query.cgi
new revision: 1.171; previous revision: 1.170
done
Checking in template/en/default/search/knob.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/knob.html.tmpl,v  <--  knob.html.tmpl
new revision: 1.19; previous revision: 1.18
done

Comment 12

[Wayne Mery (:wsmwk)]

might this also have fixed bug 325123 and bug 339270?

Comment 13

[Dave Miller [:justdave]]

(In reply to comment #12)
> might this also have fixed bug 325123 and bug 339270?

nope, neither of those is related.