365365 - Small comment textarea has spurious inline style causing CSS warnings in Error Console

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[[e-mail]]

<div id="smallCommentFrame">
          <b><label for="comment">Comment</label> (on the
          bug):</b><br><textarea name="comment" id="comment" style="
        table.attachment_info th { text-align: right; vertical-align: top; }
        table.attachment_info td { text-align: left; vertical-align: top; }
        #noview { text-align: left; vertical-align: middle; }
    
        table#flags th, table#flags td { font-size: small; vertical-align: baseline; text-align: left; }
      " wrap="soft"
            rows="5"
          cols="25"></textarea><br>
        </div>

Comment 1

[Gervase Markham [:gerv]]

The style attribute is set at the top of the attachment/edit.html.tmpl page, and isn't being cleared before the textarea.html.tmpl template is included. So we either need to fix the scoping, or just add a "style=''" to the call to textarea.html.tmpl.

Gerv

Comment 2

[Frédéric Buclin]

pyrzak, could you look at this?

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

This patch fixes the incorrect style attribute of <textarea> and also fixes all incorrectly escaped / in JS (</foo> must be <\/foo>).

Comment 4

[Frédéric Buclin]

Attachment: patch for 3.0.x, v1

Comment 5

[Frédéric Buclin]

tip:

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.46; previous revision: 1.45
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.50; previous revision: 1.49
done
Checking in template/en/default/attachment/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v  <--  show-multiple.html.tmpl
new revision: 1.25; previous revision: 1.24
done


3.0.3:

Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.31.2.4; previous revision: 1.31.2.3
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.41.2.4; previous revision: 1.41.2.3
done
Checking in template/en/default/attachment/show-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/show-multiple.html.tmpl,v  <--  show-multiple.html.tmpl
new revision: 1.22.2.1; previous revision: 1.22
done