Created attachment 717983 [details] [diff] [review] proposed patch This is my first time to submit a bug. I need someone to review my patch.
Comment on attachment 717983 [details] [diff] [review] proposed patch Looks good to me Not used: http://mxr.mozilla.org/comm-central/search?string=NS_CONSOLEMESSAGE_CONTRACTID
Comment on attachment 717983 [details] [diff] [review] proposed patch bsmedberg is listed in whiteboard as mentor, and he's an XPCOM superreviewer, so I'll ask him for review.
Carl, for future reference the steps at https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in should help you create a patch that contains your author information and a commit message. That will allow somebody to commit your patch much easier.
Created attachment 719663 [details] [diff] [review] proposed patch (mq) Thank you. I applied this patch with mq again.
I was about to push it with the amended message: Bug 365367 - NS_CONSOLEMESSAGE_CONTRACTID removed because it is never used. r=bsmedberg But the tree was closed, so it will have to wait. Thanks for the fast turnaround!
I pushed this patch to try server 1 hr ago. Should I cancel it?
Yes. I'll do it while your LDAP password problems are sorted out.