365396 - No space anymore between caret and border of text input/textareas

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

This is a regression from bug 332557, confirmed by local backout.
Normally, there is a 1px space between the caret and the border of a text input/textarea (at least on windows). That's not the case anymore with current trunk builds.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Martijn Wargers (dead)]

Attachment: Screenshots

In case it is not clear what I mean.

Comment 3

[Ria Klaassen (not reading all bugmail)]

I can only reproduce the screenshot in my default profile; not in a new profile, and it seems to depend on the presence of a code in userContent.css.

Oh well, I see now that there are two pixels space before 12 December and one pixel now. Most important is the difference.

Comment 4

[Martijn Wargers (dead)]

There is no difference for me in a new profile.
But I guess you use the windowsXP luna theme, while I use the classic theme (I forgot about this).
This reminds me of bug 326926.
I just checked IE7 and it indeed seems to use a 2px gap for the caret in the windowsXP theme and a 1px gap in the classic theme, so we need to get that 1 pixel to the right back.

Comment 5

[Boris Zbarsky [:bzbarsky]]

So the issue is that the textframe's div is reflown either as a reflow root or as a child of an nsStackFrame.  In either case, it has no parentReflowState and hence the padding for it doesn't get computed.  So when we inherit the reflow state's padding, as bug 332557 makes us do, we get 0 instead of the 1px we should be getting.

This is basically the same problem as bug 366952.

Comment 6

[Martijn Wargers (dead)]

Yeah, this is fixed now with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070117 Minefield/3.0a2pre