365404 - Updater should use brand name string and not hardcode Sunbird

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Bonilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Calendar 0.4a1 nightly 2006123004

Hello,

following the request of the developers to report any misslabeled text passages (see http://weblogs.mozillazine.org/calendar/2006/07/sunbird_generic_branding_now_o.html), I would like to file the following 'bug':

When updating to the latest nightly, the update prograss bar (after downloading and restarting) still says 'Sunbird' instead of 'Calendar'.

Greetings from Germany,

Bobby

Reproducible: Didn't try

Steps to Reproduce:
1. Click on Help > Check for Updates
2. If a new nightly release is available, let the program download it and restart
3. The progress bar that displays the installation progress says 'Sunbird'

Comment 1

[Stefan Sitter [:ssitter]]

See similar Firefox Bug 324758.

Comment 2

[Martin Schröder [:mschroeder]]

Confirming. Solution may be in bug 324758 for Firefox.

Comment 3

[Robert Strong (they/them - no direct email)]

With the landing of the patch in bug 399153 this is now very simple to fix as can be seen in the patch in bug 324758 that was checked in.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 5

[cmtalbert]

Comment on attachment 357002 [details] [diff] [review]
patch rev1

Absolutely.  I wonder how long this has been broken. :-(

Thanks for the patch. r=ctalbert

Comment 6

[Stefan Sitter [:ssitter]]

Is the patch ready for check-in or does it need to wait on some core fix on the 1.9.1 branch, e.g. Bug 473417?

Comment 7

[Robert Strong (they/them - no direct email)]

I would prefer to wait on Bug 473417 being fixed before landing this

Comment 8

[Robert Strong (they/them - no direct email)]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/3f42754a5118