Closed Bug 365404 Opened 17 years ago Closed 15 years ago

Updater should use brand name string and not hardcode Sunbird

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Version:
Mozilla 1.8 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bobby.bonilla, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

patch rev1
1.21 KB, patch
cmtalbert
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Calendar 0.4a1 nightly 2006123004

Hello,

following the request of the developers to report any misslabeled text passages (see http://weblogs.mozillazine.org/calendar/2006/07/sunbird_generic_branding_now_o.html), I would like to file the following 'bug':

When updating to the latest nightly, the update prograss bar (after downloading and restarting) still says 'Sunbird' instead of 'Calendar'.

Greetings from Germany,

Bobby

Reproducible: Didn't try

Steps to Reproduce:
1. Click on Help > Check for Updates
2. If a new nightly release is available, let the program download it and restart
3. The progress bar that displays the installation progress says 'Sunbird'
See similar Firefox Bug 324758.
Confirming. Solution may be in bug 324758 for Firefox.
Status: UNCONFIRMED → NEW
Component: General → Sunbird Only
Ever confirmed: true
OS: Windows XP → All
QA Contact: general → sunbird
Hardware: PC → All
Version: unspecified → Trunk
Severity: trivial → minor
Summary: Update progress bar saying 'Sunbird' instead of 'Calendar' → Updater should use brand name string and not hardcode Sunbird
Version: Trunk → Mozilla 1.8 Branch
With the landing of the patch in bug 399153 this is now very simple to fix as can be seen in the patch in bug 324758 that was checked in.
Attached patch patch rev1 — — Splinter Review 
Assignee: nobody → robert.bugzilla

        Attachment #357002 -
        Flags: review?(ctalbert)
Status: NEW → ASSIGNED
Target Milestone: --- → 1.0

    
  

        Attachment #357002 -
        Flags: review?(ctalbert) → review+

    
    

    
  
Comment on attachment 357002 [details] [diff] [review]
patch rev1

Absolutely.  I wonder how long this has been broken. :-(

Thanks for the patch. r=ctalbert

    
    

    
  
Is the patch ready for check-in or does it need to wait on some core fix on the 1.9.1 branch, e.g. Bug 473417?

    
    

    
  
I would prefer to wait on Bug 473417 being fixed before landing this

    
    

    
  
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/3f42754a5118
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: 1.0 → 1.0b1

          You need to log in
          before you can comment on or make changes to this bug.