365413 - [reflow branch] XUL buttons in XHTML aren't large enough to contain their labels (e.g. "Try again" button on error pages)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[(not reading, please use [e-mail] instead)]

"try again" button looks odd when I fail to connect to a server

I'm using my own build:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a2pre) Gecko/20061228 Minefield/3.0a2pre

steps to reproduce:

1)  visit http://www.sspitzer.forg

I'll attach a screen shot

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[Phil Ringnalda (:philor)]

It's actually reflow branch, rather than the cairo/cocoa your cc list would suggest: I meant to file it back then, but got thrown off by dbaron saying he didn't see it, and then forgot before I made sure I didn't break something in my own build. Now I wonder if maybe it's Intel-only.

Looks to be "XUL buttons in XHTML look odd" since the "Subscribe Now" button in a feed preview page like http://www.mozilla.org/news.rdf hangs the w and half the o off the right edge, but XUL buttons in XUL don't have the same problem.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of rss subscribe ui, that phil mentioned

thanks for the added info, phil

Comment 4

[Phil Ringnalda (:philor)]

Though, as usual, my first guess seems wrong: in Thunderbird's preferences, the buttons in Advanced - Certificates have the same problem, and don't seem to be XUL in XHTML.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Did the fix for bug 366722 help here at all?

Comment 6

[(not reading, please use [e-mail] instead)]

> Did the fix for bug 366722 help here at all?

I'm currently mac less, but perhaps colin can check?

Comment 7

[Phil Ringnalda (:philor)]

The checked-in (attachment 251289 [details] [diff] [review]) part fixes up the try again button in the error page and Thunderbird's advanced/certificates buttons perfectly, but only slightly affects the feed "subscribe now" button (now the w is just inside the border). Worst comes to worst, I'll try to testcase it, but I have high hopes that dbaron will coincidently fix it with one of his followups there.

Comment 8

[Phil Ringnalda (:philor)]

And the last bit was fixed by attachment 252939 [details] [diff] [review]