Closed Bug 365428 Opened 19 years ago Closed 19 years ago

Rename "Keyword" field as "Shortcut" to more accurately reflect its function

Categories

(Camino Graveyard :: Bookmarks, defect)

PowerPC
macOS
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.5

People

(Reporter: alqahira, Assigned: froodian)

Details

(Keywords: fixed1.8.1.2)

Attachments

(2 files, 1 obsolete file)

11.76 KB, application/zip
alqahira
: review+
stuart.morgan+bugzilla
: superreview+
Details
20.51 KB, application/zip
alqahira
: review+
stuart.morgan+bugzilla
: superreview+
Details
While thinking about the problem of making bookmark keywords/bookmark keyword searches more accessible, it occurred to me that "Keyword" is really ill-named. A keyword (to me, at least) is a generic, non-specific/non-unique bit of metadata to aid in finding an item (book, website), e.g. for a book/site "The Unauthorized History of Apple Computer" keywords might be "unauthorized, history, apple, computer, macintosh, lisa, jobs, woz" and so forth. Other books/sites on Apple might contain some of the same keywords. (In other words, keywords are basically what the Web 2.0 jargon calls "tags". iPhoto actually calls them keywords :) ) Our bookmark keywords, while perhaps originally designed as an aid to finding a bookmark in the pre-bookmarks-search days of Netscape 1.x-4.x, really meet very few of those criteria. For one thing, they're uniquely tied to a single bookmark, and each bookmark can have only one keyword. The primary purpose of keywords also isn't to help find a bookmark among all the others (searching the Manager) but instead to be a shortcut to load the site/search more quickly. (Our mis-use of keyword also seems a particularly jargon-y usage, and at least one bug - bug 338544 - seems to have been filed due to this confusion. "Shortcut" is still a little jargon-y, but it is more likely to be understood in this context. This renaming, especially if done in the 1.x era, would also free up "keyword" to be used instead of the jargon "tag" in the 2.0 bookmark rewrite.)
Another possibility would be using "abbreviation." Either is better than "keyword" IMO (for pretty much the reasons you lay out)
I'm on board with "shortcut".
Confirming, per above discussion and IRC. Should just be the two nib changes (for the bookmark panal and bm manager)
Assignee: nobody → stridey
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: Camino2.0 → Camino1.1
sounds good to me too.
Attachment #250608 - Flags: review?(alqahira)
Attached file New BookmarksEditing.nib (obsolete) —
Attachment #250609 - Flags: review?(alqahira)
Comment on attachment 250609 [details] New BookmarksEditing.nib You missed the menu for the search field in this nib.
Attachment #250609 - Flags: review?(alqahira) → review-
Comment on attachment 250608 [details] New BookmarkInfoPanel.nib r=ardissone on this one
Attachment #250608 - Flags: review?(alqahira) → review+
Whoops.
Attachment #250609 - Attachment is obsolete: true
Attachment #250793 - Flags: review?(alqahira)
Comment on attachment 250793 [details] New BookmarksEditing.nib r=ardissone Just remind me to update the list of docs that need updating when this lands ;)
Attachment #250793 - Flags: review?(alqahira) → review+
Comment on attachment 250608 [details] New BookmarkInfoPanel.nib sr=smorgan. Please file a follow-up bug to change all code references to 'keyword' though, to make things less confusing.
Attachment #250608 - Flags: superreview?(stuart.morgan) → superreview+
Comment on attachment 250793 [details] New BookmarksEditing.nib sr=smorgan
Attachment #250793 - Flags: superreview?(stuart.morgan) → superreview+
I filed bug 366976 for comment 11.
Whiteboard: [needs checkin]
Checked in on trunk and MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1.2
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: