365438 - Tag-related error messages should mention "tag" instead of "saved search"

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[victory <[e-mail]>]

Attachment: patch for tip

below errors need update due to name changed by bug 364013.
no_bug_ids
no_bugs_in_list
no_bugs_to_remove

Comment 1

[Reed Loden [:reed]]

Comment on attachment 250031 [details] [diff] [review]
patch for tip

>   [% ELSIF error == "no_bug_ids" %]
>     [% title = BLOCK %]No [% terms.Bugs %] Chosen[% END %]
>     You didn't choose any [% terms.bugs %] to
>-    [% IF action == "add" %] add to [% ELSE %] remove from [% END %]
>-    the saved search.
>+    [% IF action == "add" %] add [% ELSE %] remove [% END %]
>+    the tag.

This doesn't make sense now without the "to" or "from" in the sentence. It comes out to be "You didn't choose any bugs to add the tag." You need to keep the "add to" and "remove from" parts.

>   [% ELSIF error == "no_bugs_in_list" %]
>+    [% title = "Delete Tag?" %]
>+    You are going to remove tag '[% tag FILTER html %]' from all
>+    [% terms.bugs %].  This will delete this tag completely. Click

Maybe change to "This will delete the tag completely." (s/this/the/), though this is purely a nit.

Comment 2

[victory <[e-mail]>]

dont do stupid things unless you do fix

Comment 3

[Reed Loden [:reed]]

This bug describes a valid problem that should be fixed. Reopening.

Comment 4

[Frédéric Buclin]

As long as this bug is valid, marking it as WONTFIX isn't right. We have to be
consistent and use 'tag' where appropriate. Keep this bug open.

Comment 5

[Tiago Mello [:timello]]

Attachment: patch fixes.

Comment 6

[Reed Loden [:reed]]

Comment on attachment 274039 [details] [diff] [review]
patch fixes.

>   [% ELSIF error == "no_bugs_in_list" %]
>-    [% title = "Delete Saved Search?" %]
>-    You are going to remove all [% terms.bugs %] from the '[% saved_search FILTER html %]'
>-    saved search. This will delete this saved search completely. Click
>+    [% title = "Delete Tag?" %]
>+    You are going to remove tag '[% tag FILTER html %]' from all
>+    [% terms.bugs %]. This will delete the tag completely. Click
>     <a href="buglist.cgi?cmdtype=dorem&amp;remaction=forget&amp;namedcmd=
>-    [%- saved_search FILTER url_quote %]">here</a> if you really want to
>-    remove it.
>+    [%- tag FILTER url_quote %]">here</a> if you really want to remove it.

No, you're incorrectly changing the wording here. You don't remove a tag from a bug, you remove a bug from a tag. Use something like "You are going to remove all bugs from the <blah> tag. This will completely delete the tag. Click here if you really want to remove it."

>   [% ELSIF error == "no_bugs_to_remove" %]
>-    [% title = "No Saved Search Selected" %]
>-    You didn't select any saved search to remove [% terms.bugs %] from.
>+    [% title = "No Tag Selected" %]
>+    You didn't select any tag to remove from [% terms.bugs %].

The same thing is true here. Use something like "You didn't select a tag to remove bugs from."

Comment 7

[timeless]

... from which to remove bugs.

prepositions ending sentences, ... bad.

Comment 8

[Reed Loden [:reed]]

(In reply to comment #7)
> ... from which to remove bugs.
> 
> prepositions ending sentences, ... bad.

I highly agree, but in this case, this error message will (probably) never be seen by the user, so it really doesn't matter. However... yeah, that will do. It sounds so abnormal in normal speaking, but it is the proper method, and since this error message will never be seen, then that's fine as "from which to remove bugs."

Comment 9

[timeless]

Attachment: a few extra changes

Comment 10

[Reed Loden [:reed]]

Comment on attachment 275282 [details] [diff] [review]
a few extra changes

r=me, sorry for the delay.

Comment 11

[timeless]

Comment on attachment 275282 [details] [diff] [review]
a few extra changes

mozilla/webtools/bugzilla/buglist.cgi 	1.361
mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl 	1.228

BUGZILLA-3_0-BRANCH:
mozilla/webtools/bugzilla/buglist.cgi 	1.351.2.5
mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl 	1.204.2.7