365529 - Take advantage of new yes/no constant in nsIPrompt

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Bug 351881 added yes/no constant to nsIPrompt.  Callers that currently create it themselves should be updated.  URL field contains search for some candidate callers.

Comment 1

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch for nsHttpChannel

Patch v1 for nsHttpChannel

Comment 2

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch for nsPasswordManager

Patch v1 for nsPasswordManager

Comment 3

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch for wallet.

Comment 4

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch for nsMsgDBFolder

Patch v1 for nsMsgDBFolder.cpp

Comment 5

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch for EmbedPasswordMgr

Patch v1 for EmbedPasswordMgr.cpp

Comment 6

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch for Wallet (V2)

Previous patch had a missing license line, fixed it for this one.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 250098 [details] [diff] [review]
Patch for nsPasswordManager

No SR is needed for /browser and /toolkit (see http://www.mozilla.org/projects/firefox/review.html and http://www.mozilla.org/projects/toolkit/review.html)

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp 	1.303
mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp 	1.90
mozilla/mailnews/base/util/nsMsgDBFolder.cpp 	1.287
mozilla/extensions/wallet/src/wallet.cpp 	1.380
mozilla/embedding/browser/gtk/src/EmbedPasswordMgr.cpp 	1.5

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Can some of these patches go on branch (e.g. the nsMsgDBFolder patch)?