Closed Bug 365529 Opened 19 years ago Closed 19 years ago

Take advantage of new yes/no constant in nsIPrompt

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: csthomas, Assigned: sciguyryan)

References

(
URL
)

Details

Attachments

(5 files, 1 obsolete file)

Patch for nsHttpChannel
1018 bytes, patch
Biesinger
: review+
Biesinger
: superreview+
Details | Diff | Splinter Review
Patch for nsPasswordManager
1.05 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
Patch for nsMsgDBFolder
1.11 KB, patch
neil
: review+
neil
: superreview+
Details | Diff | Splinter Review
Patch for EmbedPasswordMgr
1.31 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
Patch for Wallet (V2)
2.28 KB, patch
Gavin
: review+
Details | Diff | Splinter Review
Bug 351881 added yes/no constant to nsIPrompt. Callers that currently create it themselves should be updated. URL field contains search for some candidate callers.
Patch v1 for nsHttpChannel
Assignee: nobody → sciguyryan+bugzilla
Status: NEW → ASSIGNED
Attachment #250097 - Flags: superreview?(cbiesinger)
Attachment #250097 - Flags: review?(cbiesinger)
Patch v1 for nsPasswordManager
Attached patch Patch for wallet. (obsolete) — — Splinter Review
Attachment #250099 - Flags: superreview?(mconnor)
Attachment #250099 - Flags: review?(mconnor)
Patch v1 for nsMsgDBFolder.cpp
Attachment #250105 - Flags: superreview?(mconnor)
Attachment #250105 - Flags: review?(mconnor)
Attachment #250098 - Flags: superreview?(gavin.sharp)
Attachment #250098 - Flags: review?(gavin.sharp)
Patch v1 for EmbedPasswordMgr.cpp
Attachment #250105 - Flags: superreview?(neil)
Attachment #250105 - Flags: superreview?(mconnor)
Attachment #250105 - Flags: review?(neil)
Attachment #250105 - Flags: review?(mconnor)
Attachment #250097 - Flags: superreview?(cbiesinger)
Attachment #250097 - Flags: superreview+
Attachment #250097 - Flags: review?(cbiesinger)
Attachment #250097 - Flags: review+
Attachment #250099 - Attachment is obsolete: true
Attachment #250099 - Flags: superreview?(mconnor)
Attachment #250099 - Flags: review?(mconnor)
Previous patch had a missing license line, fixed it for this one.
Attachment #250108 - Flags: superreview?(mconnor)
Attachment #250108 - Flags: review?(mconnor)
Comment on attachment 250098 [details] [diff] [review] Patch for nsPasswordManager No SR is needed for /browser and /toolkit (see http://www.mozilla.org/projects/firefox/review.html and http://www.mozilla.org/projects/toolkit/review.html)
Attachment #250098 - Flags: superreview?(gavin.sharp)
Attachment #250098 - Flags: review?(gavin.sharp)
Attachment #250098 - Flags: review+
Attachment #250107 - Flags: review?(gavin.sharp)
Attachment #250107 - Flags: review?(gavin.sharp) → review+
Attachment #250108 - Flags: superreview?(mconnor)
Attachment #250108 - Flags: review?(mconnor)
Attachment #250108 - Flags: review+
Attachment #250105 - Flags: superreview?(neil)
Attachment #250105 - Flags: superreview+
Attachment #250105 - Flags: review?(neil)
Attachment #250105 - Flags: review+
Whiteboard: [checkin needed]
mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp 1.303 mozilla/toolkit/components/passwordmgr/base/nsPasswordManager.cpp 1.90 mozilla/mailnews/base/util/nsMsgDBFolder.cpp 1.287 mozilla/extensions/wallet/src/wallet.cpp 1.380 mozilla/embedding/browser/gtk/src/EmbedPasswordMgr.cpp 1.5
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Can some of these patches go on branch (e.g. the nsMsgDBFolder patch)?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: