Closed
Bug 365611
Opened 19 years ago
Closed 19 years ago
crash [@ nsSVGDocument::GetRootElement] due to null mRootContent
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: asqueella, Assigned: asqueella)
References
()
Details
(Keywords: crash, testcase)
Crash Data
Attachments
(2 files, 3 obsolete files)
|
212 bytes,
image/svg+xml
|
Details | |
|
1.01 KB,
patch
|
tor
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
testcase
It's possible for a document to end up having null mRootContent and the code should deal with it.
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/base/src/nsDocument.cpp&rev=3.698#2558 has a working implementation.
(Why does SVG need a method of its own?)
|
Assignee | |
Comment 1•19 years ago
|
||
(timeless found this crash and asked me to file it)
|
|
Assignee | |
Comment 2•19 years ago
|
||
Assignee: general → asqueella
Status: NEW → ASSIGNED
Attachment #250136 -
Flags: superreview?
Attachment #250136 -
Flags: review?
|
|
Assignee | |
Updated•19 years ago
|
Attachment #250136 -
Flags: superreview?(tor)
Attachment #250136 -
Flags: superreview?
Attachment #250136 -
Flags: review?(tor)
Attachment #250136 -
Flags: review?
|
||
Comment 3•19 years ago
|
||
(In reply to comment #0)
>(Why does SVG need a method of its own?)
Dunno but I noticed that it will only return an SVG element.
Why not something simpler like this?
NS_ENSURE_ARG_POINTER(aRootElement);
*aRootElement = nsnull;
if (mRootContent)
return CallQueryInterface(mRootContent, aRootElement);
return NS_OK;
|
|
Assignee | |
Comment 5•19 years ago
|
||
Right, and I think it's okay to move the null assignment after the if too.
Attachment #250136 -
Attachment is obsolete: true
Attachment #250480 -
Flags: superreview?(tor)
Attachment #250480 -
Flags: review?(tor)
Attachment #250136 -
Flags: superreview?(tor)
Attachment #250136 -
Flags: review?(tor)
|
|
Assignee | |
Comment 7•19 years ago
|
||
Attachment #250480 -
Attachment is obsolete: true
Attachment #250483 -
Flags: superreview?(tor)
Attachment #250483 -
Flags: review?(tor)
Attachment #250480 -
Flags: superreview?(tor)
Attachment #250480 -
Flags: review?(tor)
|
|
Assignee | |
Comment 8•19 years ago
|
||
sigh. I'll attach a patch without that typo in a moment...
|
|
Assignee | |
Comment 9•19 years ago
|
||
It's sad to make two mistakes in a 5-lines patch. This one should actually build :) Sorry for all the spam.
Attachment #250483 -
Attachment is obsolete: true
Attachment #250483 -
Flags: superreview?(tor)
Attachment #250483 -
Flags: review?(tor)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #250484 -
Flags: superreview?(tor)
Attachment #250484 -
Flags: review?(tor)
Attachment #250484 -
Flags: superreview?(tor)
Attachment #250484 -
Flags: superreview+
Attachment #250484 -
Flags: review?(tor)
Attachment #250484 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [checkin needed]
|
||
Comment 10•19 years ago
|
||
mozilla/content/svg/document/src/nsSVGDocument.cpp 1.20
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha
|
|
Assignee | |
Updated•19 years ago
|
Flags: in-testsuite?
|
||
Comment 11•19 years ago
|
||
Committed reftest:
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/rootElement-null-01.svg
Flags: in-testsuite? → in-testsuite+
|
||
Updated•14 years ago
|
Crash Signature: [@ nsSVGDocument::GetRootElement]
You need to log in
before you can comment on or make changes to this bug.
Description
•