365633 - Non-localizable string when checking for updates to add-ons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Kadir Topal [:atopal]]

All strings should be localizable and thus put into dtd or property files so we localizers can access them. That's not the case here:

http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/content/extensions.xul#159

Comment 1

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch v1

Patch v1

* Adds an entity reference to extensions.dtd

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 250166 [details] [diff] [review]
Patch v1

>Index: toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd

> <!ENTITY locales.label                    "Languages">
> <!ENTITY plugins.label                    "Plugins">
> <!ENTITY update.label                     "Updates">
> <!ENTITY install.label                    "Installation">
>+<!ENTITY progressStatus.label             "Checking For Updates">

This doesn't really belong under "View labels". I'd put it at the bottom (under "Status Messages" on its own line. I also noticed that this file contains some unused entities, like cmd.enableAll/cmd.disableAll. Might be worth filing a bug on removing those, unless there are plans to start using them. Rob Strong would be the person to ask.

Comment 3

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch for checkin

Same as Patch v1 but updates to Gavin's comments.

Gavin: Should I CC Rob Strong here to see what he thinks about removing the unused strings before opening another bug?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> Gavin: Should I CC Rob Strong here to see what he thinks about removing the
> unused strings before opening another bug?

I think he watches the component and already got mail for this anyways, but sure, doesn't hurt :)

Comment 5

[Ryan Jones-Ward [:sciguyryan]]

Rob: What do you think about Gavin's idea to remove the unused entities from extensions.dtd?

Comment 6

[Robert Strong (they/them - no direct email)]

I'd like to hold off on removing them since there is another bug to add this functionality.

Comment 7

[Ryan Jones-Ward [:sciguyryan]]

(In reply to comment #6)
> I'd like to hold off on removing them since there is another bug to add this
> functionality.
> 

OK, thanks for the information :)

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd 	1.20
mozilla/toolkit/mozapps/extensions/content/extensions.xul 	1.54