365677 - Opening ics-file breaks export selection

Status: VERIFIED FIXED

(Calendar :: Import and Export, defect)

Description

[Sebastian Hengst [:aryx] [limited availability until start of 2020] (needinfo on intermittent or backout)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.9a2pre) Gecko/20070102 Calendar/0.4a1 - Build ID: 2007010203

Later, export selection was always messed up.

Reproducible: Always

Steps to Reproduce:
1.Start Sunbird.
2.Open a ics-file with events, it should be added to the calendars list.
3.Go in unifinder to the top event, click on it and scroll the list down with alt+pagedown
4.Try 'File > Export selection'
Actual Results:  
Export selection was disabled (grey).

Expected Results:  
Export selection should be enabled (black).

After first time seeing this problem, all went fine after a restart of sunbird. Now 'Export selection' seems to be always disabled.

Comment 1

[cmtalbert]

I can confirm this on Mac OS X 10.4.8
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a2pre) Gecko/20070102 Calendar/0.4a1

BuildID:2007010203

Comment 2

[Joey Minta]

Attachment: call onSelectionChange

Because we pass in |true| to the views (to avoid an infinite loop), the views never fire a select event, and the menuitems that depend on selection never get updated.  This patch manually makes the call.

Comment 3

[Matthew (lilmatt) Willis]

Comment on attachment 250780 [details] [diff] [review]
call onSelectionChange

r=lilmatt

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 250780 [details] [diff] [review]
call onSelectionChange

r2=mvl

Comment 5

[Paul Ivanov]

Just confirming:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a2pre) Gecko/20070116 Calendar/0.6a1

BuildID:2007011603

So Export Selection is greyed out until i select ALL of the events with Ctrl-A in unifinder (****/ctrl clicking with mouse didn't work), after which point it's not greyed out, even with just one event selected, and export selection works as expected.

Comment 6

[Joey Minta]

patch checked in.

Comment 7

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20070214 Calendar/0.4a1