365690 - Edit bar fires focus event on menu popup

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[parente]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a2pre) Gecko/20070102 Minefield/3.0a2pre)

1. Run at-poke and watch for focus events.
2. Put focus on the address bar. at-poke will log a focus event on the entry box. This is correct.
3. Clear the text in the address bar.
4. Type something that will make the edit bar popup show (e.g. www).
5. at-poke logs a "focus" event on the popup menu. However, the entry box still has the actual application focus as the next key press (e.g. ., left arrow, etc.) will affect the entry box, not the menu control. This seems inconsistent/incorrect.

Expected, consistent behavior would be to receive a focus event on the popup menu only once the user navigates into it (e.g. down arrow) just as the entry box receives focus when the user tabs to it, presses Alt-D, clicks on it, etc.

I do believe an event should be fired when the popup menu first appears, but I don't think "focus" is the right one.

The gail/gtk solution is to give focus to the comobox accessible, not its entry box or its list. See the autocomplete in the run dialog (Alt-F2).

Comment 1

[Aaron Leventhal]

My proposal is to keep focus and events in the edit bar, but fix it so the extra focus events in the popup aren't fired unless focus is really there.

Comment 2

[Ginn Chen]

Agree.

Make it blocking bug 332662, this bug should be fixed before that one.

Comment 3

[Aaron Leventhal]

I'm guessing this is related to the unnecessary focus events on tooltips - bug 368314.

Comment 4

[Aaron Leventhal]

Attachment: Don't fire focus events for autocomplete popups or tooltips, but do fire visible state change for them

Comment 5

[Aaron Leventhal]

Attachment: Don't fire focus for autocomplete or tooltips -- but fire state change for visible for any popup

Comment 6

[Ginn Chen]

Comment on attachment 253341 [details] [diff] [review]
Don't fire focus for autocomplete or tooltips -- but fire state change for visible for any popup

I guess we need more code on MENU_POPUPSTART/END for atk.
But it's not easy. (bug 332662)

This patch is fine for now.