Closed Bug 365886 Opened 13 years ago Closed 13 years ago

Implement canvas transform() and setTransform()

Categories

(Core :: Canvas: 2D, enhancement)

x86
Linux
enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: takenspc, Assigned: takenspc)

References

()

Details

Attachments

(2 files, 2 obsolete files)

Current Web Applications 1.0 introduces transform(m11, m12, m21, m22, dx, dy) and setTransform(m11, m12, m21, m22, dx, dy) into the canvas 2d context.

The rhino canvas implemented them already.
http://rhino-canvas.sourceforge.net/

We should implement them.
Attached patch Patch rv.1.0 (obsolete) — Splinter Review
A patch as per the spec.

Both methods uses the follow matrix:

transform(m11, m12, m21, m22, dx, dy) <->

m11 	m12 	dx
m21 	m22 	dy
0 	0 	1
Assignee: nobody → taken.spc
Status: NEW → ASSIGNED
Attached file Test case
A test case as per the updated spec.

Now, the matrix is below.
transform(m11, m12, m21, m22, dx, dy) <->

m11     m21     dx
m12     m22     dy
0       0       1
Attachment #250424 - Attachment is obsolete: true
Attached patch Patch rv.1.1 (obsolete) — Splinter Review
A new patch followed the updated spec
Attachment #251788 - Flags: review?(vladimir)
Attachment #251788 - Attachment is patch: true
Attachment #251788 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 251788 [details] [diff] [review]
Patch rv.1.1

Looks good; do you have cvs commit access?  If not, I'll get this checked in.
Attachment #251788 - Flags: review?(vladimir) → review+
(In reply to comment #4)
> (From update of attachment 251788 [details] [diff] [review])
> Looks good; do you have cvs commit access?  If not, I'll get this checked in.
> 

No, I don't. I beg of you to do so.
Attached patch Patch rv.1.1.1Splinter Review
change the uuid of |nsIDOMCanvasRenderingContext2D|.
Attachment #251788 - Attachment is obsolete: true
checked-in, thank you Taken-san.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.