The default bug view has changed. See this FAQ.

use spin controls for xul calendar

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
10 years ago
9 months ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

({fixed1.8.0.12, fixed1.8.1.4})

Trunk
fixed1.8.0.12, fixed1.8.1.4
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

10 years ago
Use spin controls for month/year fields of xhtml/xul calendars.
(Assignee)

Updated

10 years ago
No longer blocks: 353880
Depends on: 353880
(Assignee)

Updated

10 years ago
Blocks: 361997
(Assignee)

Updated

10 years ago
Assignee: xforms → surkov.alexander
(Assignee)

Comment 1

10 years ago
I'd like to do this for XUL calendar only right now.
Status: NEW → ASSIGNED
Summary: use spin controls for xhtml/xul calendars → use spin controls for xul calendar
(Assignee)

Updated

10 years ago
Blocks: 368828
(Assignee)

Comment 2

10 years ago
Created attachment 253483 [details] [diff] [review]
patch
Attachment #253483 - Flags: review?(Olli.Pettay)
(Assignee)

Comment 3

10 years ago
Olli, can you check whether bug 339080 is fixed by this bug?
(In reply to comment #3)
> Olli, can you check whether bug 339080 is fixed by this bug?
> 
Calendar looks almost ok. For some reason month field has a bit smaller
"scrollbar" than day field. Any reason for that?

Created attachment 254136 [details]
screenshot
(In reply to comment #4)
> (In reply to comment #3)
> > Olli, can you check whether bug 339080 is fixed by this bug?
> > 
> Calendar looks almost ok. For some reason month field has a bit smaller
> "scrollbar" than day field. Any reason for that?
> 
Not day, but year field.

(Assignee)

Comment 7

10 years ago
Created attachment 254139 [details] [diff] [review]
patch2

What about this?
Attachment #253483 - Attachment is obsolete: true
Attachment #254139 - Flags: review?(Olli.Pettay)
Attachment #253483 - Flags: review?(Olli.Pettay)
(Assignee)

Updated

10 years ago
Attachment #254139 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Updated

10 years ago
Attachment #254139 - Attachment is patch: true
Attachment #254139 - Flags: review?(Olli.Pettay) → review+
forgot to say that you have windows line endings in the patch.
(Assignee)

Comment 9

10 years ago
Comment on attachment 254139 [details] [diff] [review]
patch2

(In reply to comment #8)
> forgot to say that you have windows line endings in the patch.
> 
I'll fix it after Aaron's comments
Attachment #254139 - Flags: review?(aaronr)

Comment 10

10 years ago
Comment on attachment 254139 [details] [diff] [review]
patch2


>Index: extensions/xforms/resources/content/widgets-xul.xml
>===================================================================
>RCS file: /cvsroot/mozilla/extensions/xforms/resources/content/widgets-xul.xml,v
>retrieving revision 1.5
>diff -u -p -8 -r1.5 widgets-xul.xml
>--- extensions/xforms/resources/content/widgets-xul.xml	24 Jan 2007 19:54:42 -0000	1.5
>+++ extensions/xforms/resources/content/widgets-xul.xml	6 Feb 2007 08:26:00 -0000

>+  <!-- MONTHBOX -->
>+  <binding id="monthbox"
>+           extends="chrome://global/content/bindings/textbox.xml#textbox">
>+

>+      <method name="_modifyUp">
>+        <body>
>+          this.value++;
>+          this.fireEvent("spinup");
>+          this.fireEvent("change");
>+        </body>
>+      </method>
>+
>+      <method name="_modifyDown">
>+        <body>
>+          this.value--;
>+          this.fireEvent("spindown");
>+          this.fireEvent("change");
>+        </body>
>+      </method>

To be consistent, the change event should be fired before spinup or spindown.

>+
>+      <method name="fireEvent">
>+        <parameter name="aName"/>
>+        <body>
>+          var evt = document.createEvent("Events");
>+          evt.initEvent(aName, true, true);
>+          this.dispatchEvent(evt);
>+        </body>
>+      </method>
>+

To be consistent, spinup and spindown should not be cancelable.

I didn't find anything else.  r-'ing for now just to be sure that you'll be able to make those changes.
Attachment #254139 - Flags: review?(aaronr) → review-
(Assignee)

Comment 11

10 years ago
Created attachment 254809 [details] [diff] [review]
patch3
Attachment #254139 - Attachment is obsolete: true
Attachment #254809 - Flags: review?(aaronr)

Updated

10 years ago
Attachment #254809 - Flags: review?(aaronr) → review+

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 12

10 years ago
checked in by ginn.
Whiteboard: xf-to-branch

Comment 13

10 years ago
checked into 1.8 branch on 2007-04-12
checked into 1.8.0 branch on 2007-04-16
Keywords: fixed1.8.0.12, fixed1.8.1.4
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.