365988 - Label on ID/tag/attr name and Value fields not exposed to accessibility aid.

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Gary Campbell]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20061230 Minefield/3.0a2pre downloaded 12/30/06.

When the dialog opens the initial focus is on the field where one enters text to search for.  The label of this field is not spoken as a field label by a screen reader.
 Nor is it or the label for the Value field (when Search By Attribute selected) spoken when you tab to them.

Reproducible: Always

Steps to Reproduce:
1. Run a screen reader or other tool that will indicate information exposed to the accessibility system.
2. In Firefox open a web page.
3. Activate DOM Inspector (Ctrl+Shift+i or from tools menu).
4. Press Ctrl+f or open Find from the Search menu (be sure the Search By ID radio button is selected.  
5. Tab around the dialog.
6. Select each search type and tab around.

Actual Results:  
Field label ("ID" in initial case) for the text box is not spoken.  Label for Value field is also not spoken.


Expected Results:  
Field names should be spoken when the fields gain focus.


Solution: The best thing I've come up with for the first textbox is to dynamically assign a control attribute to the field label when the radio button selection changes.  Patch attached.  (There's a minor problem with this fix-- the tag is not identified when the dialog opens until you tab away and back to the field.)

Comment 1

[Gary Campbell]

Attachment: Patch that implements my fix.

This patch is my fix.  It works except that I have noticed that sometimes the field label is not spoken when the dialog first opens.

Comment 2

[Shawn Wilsher :sdwilsh]

(In reply to comment #1)
> Created an attachment (id=250531) [details]
> Patch that implements my fix.

Make sure you wrap your lines at 80 characters.

I'd suggest getting review from timeless at bemail dot org or db48x at yahoo dot com

Gary, not sure if you have editbugs rights, but do you want this bug assigned to you?

Comment 3

[Alex Vincent [:WeirdAl]]

Comment on attachment 250531 [details] [diff] [review]
Patch that implements my fix.

>+    if (deck.selectedPanel.hasAttribute("control"))
>+    {
>+      deck.selectedPanel.removeAttribute("control");
>+    }

Nit:  If an attribute doesn't exist, you can tell the DOM to remove the attribute, and it won't throw an error.  So I'd suggest not bothering with the hasAttribute check here.

Comment 4

[Gary Campbell]

Attachment: Update forcode on /mozilla/extensions/inspector (and a small fix).Apply with

Comment 5

[Shawn Wilsher :sdwilsh]

Comment on attachment 338533 [details] [diff] [review]
Update forcode on /mozilla/extensions/inspector (and a small fix).Apply with

r=sdwilsh

Comment 6

[[e-mail]]

Comment on attachment 338533 [details] [diff] [review]
Update forcode on /mozilla/extensions/inspector (and a small fix).Apply with

>   this.toggleType(window.arguments[0] ? window.arguments[0] : "id");
>   this.mOpener = window.opener.viewer;
>   
>   var txf = document.getElementById("tfText1");
>   txf.select();
>   txf.focus();
>+  this.setLabel1(0);
toggleType already calls setLabel1 so I think you don't want this.

sr=me with this fixed.

Personally I don't think this is the world's best designed dialog but improving it is probably beyound the scope of this bug. Two ideas just for the record are
(1)
[Id  |V] [          ] (textbox aria-labelledby menulist)
 {Value: [          ]}
(2)
(o) Id   [          ] (textbox aria-labelledby radio)
( ) Tag  |          |
( ) Attr |          |
   Value |          |

Comment 7

[Gary Campbell]

Attachment: Update for code on /mozilla/extensions/inspector (and another small fix).Apply with cd /mozilla; patch -p0 <finddialog20080915.pch. [Checkin: Comment 8]

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 338818 [details] [diff] [review]
Update for code on /mozilla/extensions/inspector (and another small fix).Apply with cd /mozilla; patch -p0 <finddialog20080915.pch.
[Checkin: Comment 8]

http://hg.mozilla.org/dom-inspector/rev/c80e26e79ea6

***

Please, from now on, make Hg patches.