Closed
Bug 366084
Opened 18 years ago
Closed 18 years ago
Numeric accesskeys still conflicting with tab switching
Categories
(Firefox :: Keyboard Navigation, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: zeniko, Assigned: zeniko)
References
()
Details
(Keywords: regression, verified1.8.1.2)
Attachments
(1 file)
855 bytes,
patch
|
MatsPalmgren_bugz
:
review+
beltzner
:
ui-review+
jay
:
approval1.8.1.2+
|
Details | Diff | Splinter Review |
Steps to reproduce: 1. Open a new tab and go there to http://plone.org/accessibility-info 2. Hit Alt+Shift+1 Expected result: We should have navigated to http://plone.org/. Actual result: Additionally the first tab is activated. Trivial fix following. Note: On the trunk, this issue should get fixed in bug 351310 which AFAICT will change the tab switching modifier from Alt to Ctrl.
Flags: blocking1.8.1.2?
Assignee | ||
Comment 1•18 years ago
|
||
Note that Ctrl+Alt+<number> still works for tab selection... (In reply to comment #0) > Note: On the trunk, this issue should get fixed in bug 351310. Obviously, I rather meant bug 345902. BTW: In light of such issues, I'd reconsider allowing Shift for tab selection at all (contrary to Mats' opinion in bug 345902 comment #2).
Attachment #250640 -
Flags: review?(mats.palmgren)
Comment 2•18 years ago
|
||
(In reply to comment #1) > I'd reconsider allowing Shift for tab selection at all Yeah, that's probably safest after all.
Comment 3•18 years ago
|
||
Comment on attachment 250640 [details] [diff] [review] branch patch (don't switch tabs when Shift is pressed) Looks good, r=mats
Attachment #250640 -
Flags: review?(mats.palmgren) → review+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Comment 4•18 years ago
|
||
Is this meant to be checked in the 1.8 branch only or on trunk first?
Assignee: nobody → zeniko
Assignee | ||
Comment 5•18 years ago
|
||
Comment on attachment 250640 [details] [diff] [review] branch patch (don't switch tabs when Shift is pressed) (In reply to comment #4) This is mainly a branch patch, although I'd check it into Trunk as well (just in case bug 345902 doesn't make Firefox 3).
Attachment #250640 -
Flags: approval1.8.1.2?
Comment 6•18 years ago
|
||
Please get an sr= from a UE person, preferably beltzner or mconnnor, to make sure this is the behavior we want on Linux.
Assignee | ||
Comment 7•18 years ago
|
||
Comment on attachment 250640 [details] [diff] [review] branch patch (don't switch tabs when Shift is pressed) Mike: any objections to this change in particular (and/or removing the use of Shift in this place in general - see bug 345902 comment #6)?
Attachment #250640 -
Flags: ui-review?(beltzner)
Comment 8•18 years ago
|
||
beltzner: We need a quick ui-review if this is going to make the upcoming release. Please take a look. Thanks!
Comment 9•18 years ago
|
||
Comment on attachment 250640 [details] [diff] [review] branch patch (don't switch tabs when Shift is pressed) Yeah, this looks OK to me.
Attachment #250640 -
Flags: ui-review?(beltzner) → ui-review+
Updated•18 years ago
|
Flags: blocking1.8.1.2? → blocking1.8.1.2+
Comment 10•18 years ago
|
||
Comment on attachment 250640 [details] [diff] [review] branch patch (don't switch tabs when Shift is pressed) Approved for 1.8 branch, a=jay for drivers.
Attachment #250640 -
Flags: approval1.8.1.2? → approval1.8.1.2+
Updated•18 years ago
|
Whiteboard: [checkin needed] → [checkin needed][checkin needed (1.8 branch)]
Comment 11•18 years ago
|
||
mozilla/browser/base/content/browser.js 1.753
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed][checkin needed (1.8 branch)] → [checkin needed (1.8 branch)]
Comment 12•18 years ago
|
||
mozilla/browser/base/content/browser.js 1.479.2.217
Keywords: fixed1.8.1.2
Whiteboard: [checkin needed (1.8 branch)]
Comment 13•18 years ago
|
||
Verified fixed for 1.8.1.2 - test build Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2pre) Gecko/20070129 BonEcho/2.0.0.2pre ID:2007012904 - Fedora FC 6
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.2 → verified1.8.1.2
You need to log in
before you can comment on or make changes to this bug.
Description
•