366155 - Land MXR-test into VCS (hg)

Status: VERIFIED FIXED

(Webtools Graveyard :: MXR, defect)

Description

[Dave Miller [:justdave]]

Timeless has a fork of LXR running on landfill with many improvements over our current LXR codebase.  It needs to be landed, the question that's yet to be answered is 'How?'.  There's growing support at the moment to just crash-land it.  Discussion is currently in mozilla.dev.planning in the 'LXR overhaul?' thread.

Comment 1

[Dave Miller [:justdave]]

There seems to be a lot of support for the "just crash-land it" direction.  I tend to agree.  The only real objection from anyone seems to be the lack of a security audit, but I can personally vouch that the current LXR code already sucks in that respect, and I know timeless' programming methods well enough to know he's good at avoiding introducing new security problems in perl code, so it can't possibly be worse than what's already in production (and probably better in that regard).

One other point that was brought up on IRC is that bear has supposedly been working on trying to merge our LXR with the one on Sourceforge (which we forked from 9 years ago), and the status of that is unknown.  This will probably fork us further.  Bear, what's your status? :)

Comment 2

[Mike Taylor [:bear]]

I am working on this and right now I am blending 3 different sources (mxr-test, mxr and lxr) so landing mxr-test is a great help to me.

Like timeless mentioned in IRC, I will be able to do a feature audit once mxr-test lands.

While the LXR code does show some activity in SF it's basically been in a holding pattern for many years so IMO it's in the same situation as mxr.

Comment 3

[Dave Miller [:justdave]]

The (almost) version intended to be committed to CVS is now running at http://mxr.mozilla.org/

Comment 4

[Steffen Wilberg]

What's blocking this?

Comment 5

[Dave Miller [:justdave]]

Timeless: last time I asked you about checking it in as-is on IRC you mentioned you had stuff you wanted to clean up first.  I think the assumption at that point is this would land on the trunk in lxr and we wanted a clean upgrade.

How about if we do one of the following?

1) Check in MXR as-is on a branch

or

2) Cut a branch for the existing LXR code and switch lxr.mozilla.org to that branch, then land MXR on the trunk

or 

3) create a new module for MXR and check it in as revision 1.1

My favorite options are either 2 or 3.

Comment 6

[Dave Miller [:justdave]]

And if we go for 3 it can be Hg or SVN if you'd like. :)

Comment 7

[Benjamin Smedberg]

I took the code running on mxr.mozilla.org and mxr-test.mozilla.org, tagged the CVS bases, and have committed all three versions into a mercurial repository, currently hosted at http://hg.mozilla.org/users/bsmedberg_mozilla.com/mxr/

If I can get a snapshot of the code running on mxr-test.landfill I will add that code to the repository as well.

Comment 8

[Dave Miller [:justdave]]

I'm going to consider this done.  Hg is working well.

MXR now lives at http://hg.mozilla.org/webtools/mxr/

I welcome any and all hacking on it! :)  Bugs in Webtoools :: LXR for the time being, please follow standard webtools review and so forth.