366205 - "ASSERTION: Shouldn't hit this case -- we should a be a combobox if we have no size set and no multiple set!"

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Clicking the button in the testcase triggers an assertion:

###!!! ASSERTION: Shouldn't hit this case -- we should a be a combobox if we have no size set and no multiple set!: 'Not Reached', file /Users/admin/trunk/mozilla/layout/forms/nsListControlFrame.cpp, line 1988

This assertion appears to have been added by the landing of the reflow branch.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I can't seem to reproduce this.  Can you post the stack to the assertion?

Comment 2

[Jesse Ruderman]

Attachment: stack trace (mac debug / gdb)

Hmm, I had to load it from file:/// to reproduce the assertion.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix, sort of

This seems like the right thing to do, and fixes this bug for me (I could also reproduce when loading locally only).

However, this makes the "wasDirty lied" assertion to appear a _lot_ more often (3-4 times during startup for me)...  I blame scrollbars, but maybe we want to hold off on taking this patch until the scrollbar thing is resolved?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 251149 [details] [diff] [review]
Fix, sort of

r+sr=dbaron.  I think the scrollbar thing is resolved now, no?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 251149 [details] [diff] [review]
Fix, sort of

I actually thought about this some more, and I'm not happy with this patch... this makes a reflow-only flush also flush out style reresolves, which means it becomes unsafe to do those flushes from frame code.  Sadly, we have frames which do that.  :(

Comment 6

[Boris Zbarsky [:bzbarsky]]

Bug 375436 has similar issues.  Let's see what happens there.

Comment 7

[Jesse Ruderman]

WFM, Mac trunk debug.

bz, you had a patch here, but I'm guessing based on your comments that it's no longer useful.

Comment 8

[Jesse Ruderman]

Crashtest checked in.