"ASSERTION: Shouldn't hit this case -- we should a be a combobox if we have no size set and no multiple set!"

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
12 years ago
11 years ago

People

(Reporter: jruderman, Unassigned)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
PowerPC
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
Created attachment 250736 [details]
testcase

Clicking the button in the testcase triggers an assertion:

###!!! ASSERTION: Shouldn't hit this case -- we should a be a combobox if we have no size set and no multiple set!: 'Not Reached', file /Users/admin/trunk/mozilla/layout/forms/nsListControlFrame.cpp, line 1988

This assertion appears to have been added by the landing of the reflow branch.
I can't seem to reproduce this.  Can you post the stack to the assertion?
(Reporter)

Comment 2

12 years ago
Created attachment 251033 [details]
stack trace (mac debug / gdb)

Hmm, I had to load it from file:/// to reproduce the assertion.
Created attachment 251149 [details] [diff] [review]
Fix, sort of

This seems like the right thing to do, and fixes this bug for me (I could also reproduce when loading locally only).

However, this makes the "wasDirty lied" assertion to appear a _lot_ more often (3-4 times during startup for me)...  I blame scrollbars, but maybe we want to hold off on taking this patch until the scrollbar thing is resolved?
Attachment #251149 - Flags: superreview?(dbaron)
Attachment #251149 - Flags: review?(dbaron)
Comment on attachment 251149 [details] [diff] [review]
Fix, sort of

r+sr=dbaron.  I think the scrollbar thing is resolved now, no?
Attachment #251149 - Flags: superreview?(dbaron)
Attachment #251149 - Flags: superreview+
Attachment #251149 - Flags: review?(dbaron)
Attachment #251149 - Flags: review+
Comment on attachment 251149 [details] [diff] [review]
Fix, sort of

I actually thought about this some more, and I'm not happy with this patch... this makes a reflow-only flush also flush out style reresolves, which means it becomes unsafe to do those flushes from frame code.  Sadly, we have frames which do that.  :(
Attachment #251149 - Attachment is obsolete: true
Attachment #251149 - Flags: superreview-
Attachment #251149 - Flags: superreview+
Attachment #251149 - Flags: review-
Attachment #251149 - Flags: review+
Bug 375436 has similar issues.  Let's see what happens there.
Depends on: 375436
(Reporter)

Comment 7

11 years ago
WFM, Mac trunk debug.

bz, you had a patch here, but I'm guessing based on your comments that it's no longer useful.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite?
Resolution: --- → WORKSFORME
(Reporter)

Comment 8

11 years ago
Crashtest checked in.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.