The default bug view has changed. See this FAQ.

SeaMonkey doesn't write dde server keys to the Windows Registry

RESOLVED FIXED

Status

SeaMonkey
UI Design
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Carlos Une, Assigned: Carlos Une)

Tracking

({fixed-seamonkey1.1.1})

1.8 Branch
x86
Windows XP
fixed-seamonkey1.1.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20061231 SeaMonkey/1.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2pre) Gecko/20061231 SeaMonkey/1.1

After setting up SeaMonkey as default browser, SeaMonkey doesn't write dde server keys to the Windows Registry.

Reproducible: Always

Steps to Reproduce:
1. Edit -> Preferences -> Navigator -> Set Default Browser -> OK
2. Restart SeaMonkey
3. Open the Registry Editor, then navigate to HKEY_CLASSES_ROOT\HTTP\shell\open
Actual Results:  
'ddeexec', 'ddeexec\application' and 'ddeexec\topic' subkeys don't exist

Expected Results:  
'ddeexec', 'ddeexec\application' and 'ddeexec\topic' subkeys should point to SeaMonkey

SeaMonkey writes values in HKEY_CLASSES_ROOT root directory.
(Assignee)

Comment 1

10 years ago
Created attachment 250767 [details] [diff] [review]
patch for SM-1.1

Updated

10 years ago
Assignee: general → jag
Status: UNCONFIRMED → NEW
Component: General → XP Apps
Ever confirmed: true
QA Contact: general
Version: unspecified → 1.8 Branch

Comment 2

10 years ago
Created attachment 250768 [details]
snapshot of what SeaMonkey currently does

To clarify, instead of adding the keys at the correct place, it adds them under the top-level classes key.
(Assignee)

Updated

10 years ago
Attachment #250767 - Flags: review?(neil)

Updated

10 years ago
Assignee: jag → une.crl

Comment 3

10 years ago
Comment on attachment 250767 [details] [diff] [review]
patch for SM-1.1

Over to CTho as KaiRo blames him for this code (in bug 287943 comment #7).

Note: you don't seem to close your keys anywhere.
Attachment #250767 - Flags: review?(neil) → review?(cst)
(Assignee)

Comment 4

10 years ago
Created attachment 250790 [details] [diff] [review]
closing keys
Attachment #250767 - Attachment is obsolete: true
Attachment #250767 - Flags: review?(cst)
Comment on attachment 250790 [details] [diff] [review]
closing keys

Use spaces instead of tabs in patches.

I'm not sure I'm qualified to review this... if you want me to do the review you'll need to give me time to read up on the API on MSDN.  I don't even remember doing the patch KaiRo referenced.  I also don't understand our DDE code (any more) so I'd have to (re)learn that too.

Does the bug exist in Toolkit?

Comment 6

10 years ago
Comment on attachment 250790 [details] [diff] [review]
closing keys

Maybe ere can spare the time to look at this fix.
Attachment #250790 - Flags: review?(emaijala)

Comment 7

10 years ago
Just FYI: Bug 353089 contains some info about what FF does and what changed a few month ago in their code.

Comment 8

10 years ago
Comment on attachment 250790 [details] [diff] [review]
closing keys

Sure, but it'll take me a while to get my Seamonkey build working again..

Comment 9

10 years ago
Comment on attachment 250790 [details] [diff] [review]
closing keys

Get rid of tabs and Windows  line-endings. With those changed, r=emaijala.
Attachment #250790 - Flags: review?(emaijala) → review+

Comment 10

10 years ago
Comment on attachment 250790 [details] [diff] [review]
closing keys

Don't worry about the line endings, MSYS patch doesn't seem to mind them.
The tabs do need fixing though.

>+		rc = ::RegCreateKeyEx(HKEY_CLASSES_ROOT,
>+				"http\\shell\\open\\ddeexec",
Please line up the parameters under each other.
If you think it looks better, you can list multiple parameters on one line,
but you should limit the lines to 80 characters in any case.

>+		
>+		if (REG_SUCCEEDED(rc)) {
>+			::RegSetValueEx( hKey,
>+				"",
>+				0,
>+				REG_SZ,
>+				ddeexec,
>+				sizeof ddeexec );
>+			::RegCloseKey(hKey);
>+		}
Please move the declaration of ddeexec into this block. (Similarly for topic). Also, you're not being consistent with your bracketing style; sometimes you're using ( mAppName ) and sometimes (hKey); please stick to one or the other.

>+				(unsigned char *) mAppName,
The parameter is a BYTE * is it not?
(Assignee)

Comment 11

10 years ago
Created attachment 251713 [details] [diff] [review]
tabs, line endings, variable declaration, etc
Attachment #250790 - Attachment is obsolete: true
Attachment #251713 - Flags: review?(neil)
(Assignee)

Comment 12

10 years ago
Created attachment 251719 [details] [diff] [review]
patch

RegSetValueEx function expects a const BYTE* parameter.
Attachment #251713 - Attachment is obsolete: true
Attachment #251719 - Flags: review?(neil)
Attachment #251713 - Flags: review?(neil)

Comment 13

10 years ago
Comment on attachment 251719 [details] [diff] [review]
patch

sr=me
Attachment #251719 - Flags: review?(neil) → review+

Comment 14

10 years ago
Comment on attachment 251719 [details] [diff] [review]
patch

landed on trunk

Comment 15

10 years ago
Comment on attachment 251719 [details] [diff] [review]
patch

I guess this needs to go on the branch too, right?
Attachment #251719 - Flags: approval-seamonkey1.1.1?
Attachment #251719 - Flags: approval-seamonkey1.1.1? → approval-seamonkey1.1.1+

Comment 16

10 years ago
Comment on attachment 251719 [details] [diff] [review]
patch

I landed this on the 1.8 branch
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed-seamonkey1.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.