366367 - SeaMonkey link on mailnews start page is incorrect in suiterunner

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Mark Banner (:standard8)]

Start up mailnews in suiterunner. On the "Welcome to SeaMonkey Mail & Newsgroups" banner, SeaMonkey links to http://www.mozilla.org/ - it should link to http://www.mozilla.org/projects/seamonkey/

The problem is that the mailnews start page (http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/start.xhtml) 
uses vendorURL (http://lxr.mozilla.org/seamonkey/search?string=vendorURL) which is defined in toolkit's region.dtd. xpfe SeaMonkey defines this in region.properties.

I guess what we should do is define vendorURL as a pref pointing to brand.properties, and use the urlformatter in a similar style to the other urls in the start.xhtml page to set the title correctly.

I don't think this will cause any problems - from what I can tell the vendorURL in toolkit is not required or doesn't have any significant affect.

Comment 1

[Robert Kaiser]

As a note, the localized pref to use through urlformatter should probably be app.vendorURL - and we probably should file a bug for http://lxr.mozilla.org/seamonkey/source/toolkit/content/about.xhtml#63 to use the same pref.

Comment 2

[Bruno 'Aqualon' Escherl]

Attachment: define vendorURL as pref and use URLFormatterService

Comment 3

[Robert Kaiser]

Comment on attachment 251231 [details] [diff] [review]
define vendorURL as pref and use URLFormatterService

>Index: suite/locales/en-US/chrome/branding/brand.properties
>===================================================================
> app.releaseNotesURL=http://www.mozilla.org/projects/seamonkey/releases/seamonkey%VERSION%/
> keyword.moreInfoURL=http://www.mozilla.org/docs/end-user/internet-keywords.html
>+app.vendorURL=http://www.mozilla.org/projects/seamonkey/

Nit: Move the new entry one line up so the two app.* ones are next to each other.

r=me

Comment 4

[[e-mail]]

Comment on attachment 251231 [details] [diff] [review]
define vendorURL as pref and use URLFormatterService

Oh, don't forget to update xpfe's browser-prefs.js too.

Comment 5

[Bruno 'Aqualon' Escherl]

Attachment: Previous patch including review comments

Comment 6

[Karsten Düsterloh]

Landed on trunk.