Closed Bug 366386 Opened 18 years ago Closed 16 years ago

ServicesLogin does not identify before joining channels

Categories

(Webtools Graveyard :: Mozbot, defect, P1)

Product:
Webtools Graveyard
Component:
Mozbot
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wolf, Assigned: wolf)

Details

(Whiteboard: [has-patch])

Attachments

(1 file)

Patch v1
3.94 KB, patch
Details | Diff | Splinter Review 
When mozbot's configured to identify with nickserv on startup, the identify command does not get sent until after the bot has already joined channels. This prevents the bot from being automatically given op/halfop/etc privledges in the channels in joins.
Attached patch Patch v1 — — Splinter Review 
Make scheduled commands get initialized before joining channels.
Make ServicesLogin skip the message queue, by using privmsg instead of sendmsg.

I've tested these changes on a local mozbot and there have been no regressions that I can find. I plan on testing this patch on firebot, which is more active to make sure though.
Assignee: ian → bugtrap
Status: NEW → ASSIGNED
Attachment #250917 - Flags: review?(wicked+bz)
Attachment #250917 - Flags: review?(ian)
Whiteboard: [in-firebot]
Whiteboard: [in-firebot] → [has-attachment][in-firebot]
Whiteboard: [has-attachment][in-firebot] → [has-attachment]
Attachment #250917 - Flags: review?(wicked)
Attachment #250917 - Flags: review?(ian)
Priority: -- → P1
Whiteboard: [has-attachment] → [has-patch]
Checking in mozbot.pl;
/cvsroot/mozilla/webtools/mozbot/mozbot.pl,v  <--  mozbot.pl
new revision: 2.54; previous revision: 2.53
done
Checking in BotModules/ServicesLogin.bm;
/cvsroot/mozilla/webtools/mozbot/BotModules/ServicesLogin.bm,v  <--  ServicesLogin.bm
new revision: 2.3; previous revision: 2.2
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: