correct misleading function names in fipstest

RESOLVED FIXED in 3.12

Status

NSS
Tools
P2
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Nelson Bolyard (seldom reads bugmail))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Some of the functions in fipstest.c are named the opposite of what they do.  
e.g. functions named "hex_from_<something>" actually convert values FROM 
hex ASCII to binary, and functions named "<something>_from_hex" convert 
FROM binary TO hex ASCII.  

I propose to rename these functions as follows:
-hex_from_2char(const char *c2, unsigned char *byteval)
+hex_to_byteval(const char *c2, unsigned char *byteval)

-char2_from_hex(unsigned char byteval, char *c2, char a)
+byteval_to_hex(unsigned char byteval, char *c2, char a)
(Assignee)

Comment 1

11 years ago
Created attachment 250922 [details] [diff] [review]
patch v1

Glen, please review for the trunk.
Attachment #250922 - Flags: review?(glen.beasley)

Comment 2

11 years ago
Comment on attachment 250922 [details] [diff] [review]
patch v1

looks good.
Attachment #250922 - Flags: review?(glen.beasley) → review+
(Assignee)

Comment 3

11 years ago
Checking in fipstest.c; new revision: 1.33; previous revision: 1.32
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Priority: -- → P2
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.