Closed
Bug 366390
Opened 19 years ago
Closed 19 years ago
correct misleading function names in fipstest
Categories
(NSS :: Tools, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12
People
(Reporter: nelson, Assigned: nelson)
Details
Attachments
(1 file)
|
12.98 KB,
patch
|
glenbeasley
:
review+
|
Details | Diff | Splinter Review |
Some of the functions in fipstest.c are named the opposite of what they do.
e.g. functions named "hex_from_<something>" actually convert values FROM
hex ASCII to binary, and functions named "<something>_from_hex" convert
FROM binary TO hex ASCII.
I propose to rename these functions as follows:
-hex_from_2char(const char *c2, unsigned char *byteval)
+hex_to_byteval(const char *c2, unsigned char *byteval)
-char2_from_hex(unsigned char byteval, char *c2, char a)
+byteval_to_hex(unsigned char byteval, char *c2, char a)
|
Assignee | |
Comment 1•19 years ago
|
||
Glen, please review for the trunk.
Attachment #250922 -
Flags: review?(glen.beasley)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 250922 [details] [diff] [review]
patch v1
looks good.
Attachment #250922 -
Flags: review?(glen.beasley) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Checking in fipstest.c; new revision: 1.33; previous revision: 1.32
Status: NEW → RESOLVED
Closed: 19 years ago
Priority: -- → P2
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•