Last Comment Bug 366390 - correct misleading function names in fipstest
: correct misleading function names in fipstest
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: 3.10
: All All
: P2 minor (vote)
: 3.12
Assigned To: Nelson Bolyard (seldom reads bugmail)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-08 17:32 PST by Nelson Bolyard (seldom reads bugmail)
Modified: 2007-01-09 20:15 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (12.98 KB, patch)
2007-01-08 17:33 PST, Nelson Bolyard (seldom reads bugmail)
glenbeasley: review+
Details | Diff | Splinter Review

Description Nelson Bolyard (seldom reads bugmail) 2007-01-08 17:32:20 PST
Some of the functions in fipstest.c are named the opposite of what they do.  
e.g. functions named "hex_from_<something>" actually convert values FROM 
hex ASCII to binary, and functions named "<something>_from_hex" convert 
FROM binary TO hex ASCII.  

I propose to rename these functions as follows:
-hex_from_2char(const char *c2, unsigned char *byteval)
+hex_to_byteval(const char *c2, unsigned char *byteval)

-char2_from_hex(unsigned char byteval, char *c2, char a)
+byteval_to_hex(unsigned char byteval, char *c2, char a)
Comment 1 Nelson Bolyard (seldom reads bugmail) 2007-01-08 17:33:31 PST
Created attachment 250922 [details] [diff] [review]
patch v1

Glen, please review for the trunk.
Comment 2 glen beasley 2007-01-09 16:08:51 PST
Comment on attachment 250922 [details] [diff] [review]
patch v1

looks good.
Comment 3 Nelson Bolyard (seldom reads bugmail) 2007-01-09 20:15:10 PST
Checking in fipstest.c; new revision: 1.33; previous revision: 1.32

Note You need to log in before you can comment on or make changes to this bug.