366390 - correct misleading function names in fipstest

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

Some of the functions in fipstest.c are named the opposite of what they do.  
e.g. functions named "hex_from_<something>" actually convert values FROM 
hex ASCII to binary, and functions named "<something>_from_hex" convert 
FROM binary TO hex ASCII.  

I propose to rename these functions as follows:
-hex_from_2char(const char *c2, unsigned char *byteval)
+hex_to_byteval(const char *c2, unsigned char *byteval)

-char2_from_hex(unsigned char byteval, char *c2, char a)
+byteval_to_hex(unsigned char byteval, char *c2, char a)

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

Glen, please review for the trunk.

Comment 2

[glen beasley]

Comment on attachment 250922 [details] [diff] [review]
patch v1

looks good.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Checking in fipstest.c; new revision: 1.33; previous revision: 1.32