Closed Bug 366398 Opened 17 years ago Closed 17 years ago

On Darwin, Makefile.ref using libtool incorrectly builds libjs.so as a static library

Categories

(Core :: JavaScript Engine, defect)

All
macOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: crowderbt, Assigned: crowderbt)

References

Details

(Keywords: fixed1.8.0.10, fixed1.8.1.2)

Attachments

(2 files)

This can be proven by using the "file" command on the .so output, or by diffing libjs.a versus libjs.so; they are identical files.

Should instead use gcc with -dynamiclib option, and the result should be named libjs.dylib instead of libjs.so.  Or, this bug should go away when I finally get around to doing a configure script in bug 97954
Attached patch fix v1Splinter Review
In Darwin.mk:  No longer using libtool, instead using $(CC) -dynamiclib (this seems to be a recommendation of the Mac OS X developer docs).  Also, in jsatom.c, two debug variables had to be made static to correct linker whining.
Comment on attachment 250930 [details] [diff] [review]
fix v1

Dunno if you're the right reviewer for this or not, Brendan.  Who else should I consult for Mac OS X build-advice?
Attachment #250930 - Flags: review?(brendan)
Comment on attachment 250930 [details] [diff] [review]
fix v1

Trying bsmedberg on review, since this is a build thing (with Makefile.ref, not the main moz/ff build, but there you have it)
Attachment #250930 - Flags: review?(brendan) → review?(benjamin)
Assignee: general → crowder
Status: NEW → ASSIGNED
Attachment #250930 - Flags: review?(benjamin) → review+
Due to some CVS mishaps on my part, this landed in two pieces:
config/Darwin.mk:  1.4
jsatom.c: 3.90
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Backed this out, since it causes the branch builds to break.  Why do we have config/ and editline/ ONLY on the main trunk again???

Checking in jsatom.c;
/cvsroot/mozilla/js/src/jsatom.c,v  <--  jsatom.c
new revision: 3.91; previous revision: 3.90
done
Checking in config/Darwin.mk;
/cvsroot/mozilla/js/src/config/Darwin.mk,v  <--  Darwin.mk
new revision: 1.5; previous revision: 1.4
done
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 250930 [details] [diff] [review]
fix v1

The jsatom.c changes from this need to propogate to the branches to prevent build-breakage.  It's a simple matter of making two variables static.
Attachment #250930 - Flags: approval1.8.1.2?
Attachment #250930 - Flags: approval1.8.0.10?
Comment on attachment 250930 [details] [diff] [review]
fix v1

approved for 1.8/1.8.0 branches, a=dveditz for drivers
Attachment #250930 - Flags: approval1.8.1.2?
Attachment #250930 - Flags: approval1.8.1.2+
Attachment #250930 - Flags: approval1.8.0.10?
Attachment #250930 - Flags: approval1.8.0.10+
Whiteboard: needs landing
Crowder:  What's left to do here?  Can you get this landed on the branches asap (if the issues that resulted in the previous backout have been resolved)?
This is -just- the jsatom.c fix (making two debug variables static), which I am landing on the branches.
Attachment #254038 - Flags: review+
1.8:
Checking in jsatom.c;
/cvsroot/mozilla/js/src/jsatom.c,v  <--  jsatom.c
new revision: 3.65.4.6; previous revision: 3.65.4.5
done


1.8.0:
Checking in jsatom.c;
/cvsroot/mozilla/js/src/jsatom.c,v  <--  jsatom.c
new revision: 3.65.4.1.4.2; previous revision: 3.65.4.1.4.1
done

Trunk:
Checking in jsatom.c;
/cvsroot/mozilla/js/src/jsatom.c,v  <--  jsatom.c
new revision: 3.92; previous revision: 3.91
done
Checking in config/Darwin.mk;
/cvsroot/mozilla/js/src/config/Darwin.mk,v  <--  Darwin.mk
new revision: 1.6; previous revision: 1.5
done
Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
Whiteboard: needs landing
Adding fixed1.8.x.x keywords since this has landed on the branches.
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.