Last Comment Bug 366410 - ff/tb crashes when gtk settings are changed [@nsLookAndFeel::InitColors()]
: ff/tb crashes when gtk settings are changed [@nsLookAndFeel::InitColors()]
: crash, fixed1.8.1.2
Product: Core
Classification: Components
Component: Widget: Gtk (show other bugs)
: 1.8 Branch
: x86 Linux
-- major (vote)
: ---
Assigned To: Wolfgang Rosenauer [:wolfiR]
Depends on:
  Show dependency treegraph
Reported: 2007-01-09 00:43 PST by Wolfgang Rosenauer [:wolfiR]
Modified: 2011-06-09 14:58 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

trunk patch (5.51 KB, patch)
2007-01-10 00:18 PST, Wolfgang Rosenauer [:wolfiR]
no flags Details | Diff | Splinter Review
patch #2 (trunk) (3.56 KB, patch)
2007-01-10 00:32 PST, Wolfgang Rosenauer [:wolfiR]
roc: review+
roc: superreview+
Details | Diff | Splinter Review
patch (1.8) (3.32 KB, patch)
2007-01-11 01:23 PST, Wolfgang Rosenauer [:wolfiR]
dveditz: approval1.8.1.2+
Details | Diff | Splinter Review

Description User image Wolfgang Rosenauer [:wolfiR] 2007-01-09 00:43:22 PST
If gnome-settings-daemon is not running and will be triggered to load (e.g. from gnome-fonts-properties) Firefox (and Thunderbird) crashes. The same if gnome-settings-daemon is killed.
This is
Comment 1 User image Wolfgang Rosenauer [:wolfiR] 2007-01-09 22:08:29 PST
This seems to happen if gnome-settings-daemon takes over control over gtk settings from gtk configfiles since it happens reproducable if gnome-settings-daemon is started or killed. So it could be that a bug in GTK triggers the crash (while I'm not an expert in GTK space)
Comment 2 User image timeless 2007-01-09 23:53:54 PST
1829   g_return_val_if_fail (GTK_IS_SETTINGS (settings), NULL);,503&rev=

Incident ID: 28173161 
Stack Signature nsLookAndFeel::InitColors() 5d9ddc6c 
Product ID Firefox2 
Build ID 2006120814 
Trigger Time 2007-01-09 00:08:10.0 
Platform LinuxIntel 
Operating System Linux 
Module firefox-bin + (001f1b94) 
URL visited  
User Comments started gnome-font-properties (and therefore gnome-session-daemon) 
Since Last Crash 0 sec 
Total Uptime 0 sec 
Trigger Reason SIGSEGV: Segmentation Fault: (signal 11) 
Source File, Line No. /builds/tinderbox/Fx-Mozilla1.8-release/Linux_2.4.21-27.0.4.EL_Depend/mozilla/widget/src/gtk2/nsLookAndFeel.cpp, line 503 
Stack Trace  

nsLookAndFeel::InitColors()  [mozilla/widget/src/gtk2/nsLookAndFeel.cpp, line 503]
nsLookAndFeel::LookAndFeelChanged()  [mozilla/widget/src/gtk2/nsLookAndFeel.cpp, line 575]
nsPresContext::ThemeChanged()  [mozilla/layout/base/nsPresContext.cpp, line 1207]
PresShell::HandleEvent()  [mozilla/layout/base/nsPresShell.cpp, line 6064]
nsViewManager::HandleEvent()  [mozilla/view/src/nsViewManager.cpp, line 848]
nsViewManager::DispatchEvent()  [mozilla/view/src/nsViewManager.cpp, line 2246]
HandleEvent()  [mozilla/view/src/nsView.cpp, line 251]
nsCommonWidget::DispatchEvent()  [mozilla/widget/src/gtk2/nsCommonWidget.cpp, line 219]
nsWindow::ThemeChanged()  [mozilla/widget/src/gtk2/nsWindow.cpp, line 2010]
nsWindow::ThemeChanged()  [mozilla/widget/src/gtk2/nsWindow.cpp, line 2023] + 0x167d9 (0xf79a37d9) + 0x9c0b (0xf7996c0b) + 0x1b021 (0xf79a8021) + 0x1c247 (0xf79a9247) + 0x1c415 (0xf79a9415) + 0xe051 (0xf799b051) + 0xa9df (0xf79979df) + 0xe761 (0xf799b761) + 0x19113b (0xf7c5b13b) + 0x1798e4 (0xf7c438e4) + 0x179c23 (0xf7c43c23) + 0x167d9 (0xf79a37d9) + 0x9c0b (0xf7996c0b) + 0x1ad3d (0xf79a7d3d) + 0x1c247 (0xf79a9247) + 0x1c415 (0xf79a9415) + 0xe051 (0xf799b051) + 0xa9df (0xf79979df) + 0xfc02 (0xf799cc02) + 0x1932f6 (0xf7c5d2f6) + 0x12c7b8 (0xf7bf67b8) + 0x4202a (0xf7a8a02a) + 0x2dde2 (0xf7921de2) + 0x30e1f (0xf7924e1f) + 0x311c9 (0xf79251c9) + 0x12ccd4 (0xf7bf6cd4)
nsAppShell::Run()  [mozilla/widget/src/gtk2/nsAppShell.cpp, line 141]
nsAppStartup::Run()  [mozilla/toolkit/components/startup/src/nsAppStartup.cpp, line 152]
XRE_main()  [mozilla/toolkit/xre/nsAppRunner.cpp, line 2446]
main()  [mozilla/browser/app/nsBrowserApp.cpp, line 62] + 0x15f9c (0xf73b8f9c)

crash is simple. style is null.
Comment 3 User image Wolfgang Rosenauer [:wolfiR] 2007-01-10 00:18:22 PST
Created attachment 251041 [details] [diff] [review]
trunk patch

This only adds an if (style) around the code.
Comment 4 User image Wolfgang Rosenauer [:wolfiR] 2007-01-10 00:32:44 PST
Created attachment 251043 [details] [diff] [review]
patch #2 (trunk)

I guess I was a bit fast with the first one :-(
Comment 5 User image Robert O'Callahan (:roc) (email my personal email if necessary) 2007-01-10 10:51:30 PST
If style is null the results are pretty bad, right? These colors don't get initialized?
Comment 6 User image Wolfgang Rosenauer [:wolfiR] 2007-01-10 21:55:58 PST
As it only happens for me if control is switched from gnome-settings-daemon to config-file based config (where I don't know at all what GTK is doing exactly) I've just checked what happens now if I kill gnome-settings-daemon when I had a different theme configured in it.
Firefox still changed it's menu colors so I guess we have more than one event and the changes still get applied.
Comment 7 User image Wolfgang Rosenauer [:wolfiR] 2007-01-10 22:05:38 PST
I also checked tooltip colors and it still seems to work as expected.
Comment 8 User image Wolfgang Rosenauer [:wolfiR] 2007-01-11 01:23:41 PST
Created attachment 251159 [details] [diff] [review]
patch (1.8)

That's the same for 1.8 branch.
Comment 9 User image Wolfgang Rosenauer [:wolfiR] 2007-01-11 01:29:04 PST
commited to trunk and waiting some time until requesting approval for 1.8branch.
Comment 10 User image Wolfgang Rosenauer [:wolfiR] 2007-01-14 23:28:48 PST
Comment on attachment 251159 [details] [diff] [review]
patch (1.8)

Fixes a crasher on Linux which can easily happen if you don't run Gnome.
Comment 11 User image Daniel Veditz [:dveditz] 2007-01-16 15:49:57 PST
Comment on attachment 251159 [details] [diff] [review]
patch (1.8)

approved for 1.8 branch, a=dveditz for drivers

Note You need to log in before you can comment on or make changes to this bug.