366417 - Adding <html:script src="data:..."> to XUL document no longer executes the script

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

When an <html:script> element with src="data:text/javascript,..." is added to a XUL document, it never executes.  When I do the same in an HTML document or with the src loaded from http, it works fine.

This regressed between 2006-11-03 and 2006-11-04.  Maybe it's a regression from bug 343730?

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Jesse Ruderman]

This breaks a Greasemonkey script I rely on for testing Firefox.

Comment 3

[Damon Sicore (:damons)]

Is this going to make A5?  If not, let's move please.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

This should fix it. The problem is that when we create the nsScriptLoader we're already inside a BeginUpdate, so the blockercount gets out of sync with the update level.

An alternative fix would be to make the nsDocument ctor create a scriptloader right away. Since nsContentSink forces creation of the scriptloader it happens most of the time anyway.

I'll attach a mochitest tomorrow.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I think eagerly creating the script loader is probably simpler conceptually (and may allow us to remove some null-checks too, right)?

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch v2

Ok, this sets up the scriptloader in the ctor instead, and renames GetScriptLoader to ScriptLoader

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 266655 [details] [diff] [review]
Patch v2

Looks great!

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: branch version

Same as above, but without the /GetScriptLoader/ScriptLoader/ rename.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Patch checked in. Keeping open for a mochikit test to be written

Comment 10

[Mike Connor [:mconnor]]

moving to a6 for the test to land

Comment 11

[Nickolay_Ponomarev]

tweaking the summary to disambiguate from bug 304786.

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Marking fixed, tracking the testcase using the flag instead.

Comment 13

[Daniel Veditz [:dveditz]]

Comment on attachment 266659 [details] [diff] [review]
branch version

approved for 1.8.1.5 and 1.8.0.13, a=dveditz for release-drivers

Comment 14

[Adam Guthrie]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5pre) Gecko/20070712 BonEcho/2.0.0.5pre

Jonas landed this on branch on 2007-07-11 15:16, FWIW. 

That said, the testcase works for me in 2.0.0.4 and in today's branch build, so marking as VERIFIED (since this works on trunk), but NOT adding the verified1.8.1.5 keyword.

Comment 15

[Daniel Veditz [:dveditz]]

closing the tree for 1.8.0.13 soon, will you be able to land this patch?

Comment 16

[Daniel Veditz [:dveditz]]

Comment on attachment 266659 [details] [diff] [review]
branch version

not a blocker, misses the train