366525 - resizing the browser window can lead to an infinite loop of the tab overflow scroll buttons hiding and showing

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(not reading, please use [e-mail] instead)]

resizing the browser window can lead to an infinite loop of the tab overflow scroll buttons hiding and showing

vlad showed this to beltzner and me with a trunk build on windows, but he mentioned that dan mills verified he could make it happen on fx 2 on mac.

it looks like we are getting into a state where the overflow and underflow handlers are being called in a vicious cycle.  (see http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/tabbrowser.xml#2546)

with the default tabClipWidth and tabMinWidth settings, do this:

1) open 10 tabs
2) type this into the url bar:

javascript:window.resizeTo(1100,400);javascript:window.resizeTo(1050,400);

that will resize the window to 1110 pixels and quickly resize to 1050 pixels.

on my trunk windows build, that sends the tab bar into a fit.

I'll try on mac as well.

Comment 1

[(not reading, please use [e-mail] instead)]

on a related note, vlad also pointed out (and i confirmed) that it appears that our onResize() handler is not called as frequently on the trunk as it is on the fx2 branch, meaning as I resize I'm not seeing the tab strip adjust like it does on the fx2 branch.

see http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/tabbrowser.xml#2649

I'll confirm and log a spin off bug.

Comment 2

[(not reading, please use [e-mail] instead)]

on my mac trunk debug build, this does the trick with 10 tabs:

javascript:window.resizeTo(1100,400);javascript:window.resizeTo(1020,400);

Comment 3

[(not reading, please use [e-mail] instead)]

I have not been able to reproduce this problem (or the one in comment #1) on fx 2.0 mac.  dan, can you double check that you saw this bug in fx 2 (and not the trunk?)

Comment 4

[(not reading, please use [e-mail] instead)]

on windows, you may need this url instead:

javascript:window.resizeTo(500,400);javascript:window.resizeTo(1100,400);javascript:window.resizeTo(1050,400);

Comment 5

[(not reading, please use [e-mail] instead)]

I don't see this problem (or the one in comment #1) on fx 2.0 windows, either.

Comment 6

[Asaf Romano (gone)]

Attachment: does this help?

untested.

Comment 7

[(not reading, please use [e-mail] instead)]

asaf, is that patch for this bug (or the one in comment #1, that I need to spin off?)

Comment 8

[Asaf Romano (gone)]

This one, so I hope.

Comment 9

[Asaf Romano (gone)]

<gavin_>	ManoZZZ: + if (handleResize shouldn't that be self.handleResize?
<ManoZZZ>	gavin_: right

Comment 10

[(not reading, please use [e-mail] instead)]

this looks like a dup of bug #365477, which contains a patch (pending review) to layout and toolkit.

Comment 11

[(not reading, please use [e-mail] instead)]

thunder, can you confirm if this is a problem with fx 2.0 mac?

Comment 12

[Dan Mills [:thunder]]

It is not a problem on 2.0 on the mac.  The problem appears to be specific to the trunk.

Comment 14

[Mats Palmgren (inactive)]

Fixed by bug 365477.