Closed Bug 366537 Opened 17 years ago Closed 17 years ago

[FIX]"ASSERTION: How did our kid's height change if nothing was dirty?"

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

testcase
502 bytes, application/xhtml+xml
Details
Fix
2.02 KB, patch
dbaron
: review+
dbaron
: superreview+
Details | Diff | Splinter Review 
Loading the testcase triggers an assertion:

###!!! ASSERTION: How did our kid's height change if nothing was dirty?: 'oldVisibleHeight == GetScrolledFrame()->GetSize().height', file /Users/admin/trunk/mozilla/layout/forms/nsListControlFrame.cpp, line 674
Attached file testcase — 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix
        — 
          — Splinter Review
      

    


  
Fieldsets weren't propagating their dirty bits correctly -- they were just marking their parent as having a dirty child, when they should be marking the entire ancestor chain.

        Attachment #251086 -
        Flags: superreview?(dbaron)

        Attachment #251086 -
        Flags: review?(dbaron)

    
  
Assignee: nobody → bzbarsky
OS: Mac OS X → All
Hardware: Macintosh → All
Summary: "ASSERTION: How did our kid's height change if nothing was dirty?" → [FIX]"ASSERTION: How did our kid's height change if nothing was dirty?"

    
  

        Attachment #251086 -
        Flags: superreview?(dbaron)

        Attachment #251086 -
        Flags: superreview+

        Attachment #251086 -
        Flags: review?(dbaron)

        Attachment #251086 -
        Flags: review+

    
    

    
  
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

    
    

    
  
Crashtest checked in.
Flags: in-testsuite+

          You need to log in
          before you can comment on or make changes to this bug.