366557 - Small memory leaks in selfserv.

Status: RESOLVED FIXED

(NSS :: Tools, defect, P4)

Description

[Slavomir Katuscak]

Selfserv uses strdup() when parsing command line options and this memory is never released. It's just small amount of memory, but these leaks shows up in every memory leak test.

Comment 1

[Alexei Volkov]

Attachment: fix for main/strdup leaks

Comment 2

[Alexei Volkov]

Attachment: use PORT_Strdup and PORT_Free instead of PL_ functions

Comment 3

[Alexei Volkov]

committed into trunk:

/cvsroot/mozilla/security/nss/cmd/selfserv/selfserv.c,v  <--  selfserv.c
new revision: 1.76; previous revision: 1.75

Comment 4

[Slavomir Katuscak]

It's crashing, here is the stack:

(gdb) bt
#0  0x00000032561691d6 in free () from /lib64/tls/libc.so.6
#1  0x0000002a95bc9503 in PR_Free (ptr=0x413275) at ../../../../pr/src/malloc/prmem.c:490
#2  0x0000002a9584f720 in PORT_Free (ptr=0x413275) at secport.c:152
#3  0x0000000000408f5e in main (argc=15, argv=0x7fbfffeeb8) at selfserv.c:2056

/share/builds/mccrel3/security/securitytip/builds/20070313.1/wozzeck_Solaris8/mozilla/tests_results/security/nssamdrhel4.3/client full of cores.

Comment 5

[Slavomir Katuscak]

This core found on Linux 2.6 (nssamdrhel4), 64bit DBG build.

Comment 6

[Alexei Volkov]

Attachment: fix selfserv crash created by prev patch

Did check how certPrefix was initialized. Assumed it to be inited NULL. Instead it was initialized with stack allocated empty string.

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 258472 [details] [diff] [review]
fix selfserv crash created by prev patch

I'd like to suggest a simpler patch for this.  
Here is an outline of it.

>     PRBool               debugCache = PR_FALSE; /* bug 90518 */
>+    char                 emptyString[] = { "" };
>     char*                certPrefix = emptyString;


>-    if (certPrefix) {
>+    if (certPrefix && certPrefix != emptyString) {
>         PORT_Free(certPrefix);
>     }

Comment 8

[Alexei Volkov]

Attachment: patch with suggested fix

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 258480 [details] [diff] [review]
patch with suggested fix

r=nelson

Comment 10

[Alexei Volkov]

Comment on attachment 258480 [details] [diff] [review]
patch with suggested fix

second review for the branch

Comment 11

[Alexei Volkov]

/cvsroot/mozilla/security/nss/cmd/selfserv/selfserv.c,v  <--  selfserv.c
new revision: 1.77; previous revision: 1.76

Comment 12

[Neil Williams]

Comment on attachment 258480 [details] [diff] [review]
patch with suggested fix

r=naw

Comment 13

[Julien Pierre]

Alexei, is this fixed ? If so, please check into the branch and close the bug. Thanks.

Comment 14

[Alexei Volkov]

both fixes are checked into 3.11 branch.