Closed Bug 366589 Opened 16 years ago Closed 16 years ago

Avoid places URIs parsing in the history sidebar as much as possible

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 3 alpha2

People

(Reporter: asaf, Assigned: asaf)

References

Details

Attachments

(1 file)

We should not set gHistoryTree.place for every change in sort/grouping/search term in the history sidebar. Doing so is [supposed to be] slower than setting these options on the result/options objects. Once we fix that, we can also use OptionsFilter to persist the sidebar's mode.
Assignee: nobody → mano
Priority: -- → P2
Target Milestone: --- → Firefox 3 alpha2
Attached patch patchSplinter Review
Attachment #251135 - Flags: review?(sspitzer)
Comment on attachment 251135 [details] [diff] [review]
patch

r=sspitzer
Attachment #251135 - Flags: review?(sspitzer) → review+
dan will be interested in this clean up, for his work on the bookmarks sidebar.
mozilla/browser/components/places/content/history-panel.xul 1.5
mozilla/browser/components/places/content/history-panel.js 1.8
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.