Closed
Bug 366619
Opened 18 years ago
Closed 18 years ago
Move nsAutoLock and nsAutoMonitor to the glue
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Unassigned)
Details
Attachments
(1 file)
5.39 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
These classes are very valuable to XULRunner apps and should be exposed via the XPCOM glue.
The attached patch requires that nsAutoLock.h and nsAutoLock.cpp be moved from xpcom/threads to xpcom/glue.
One issue that I ran into is that nsAutoLock uses plhash functions that don't seem to be exported by nspr4.lib. In order to successfully link components I had to also link with plds4.lib. Is this avoidable?
Attachment #251125 -
Flags: review?(benjamin)
Comment 1•18 years ago
|
||
Comment on attachment 251125 [details] [diff] [review]
Patch
I don't care about the cvs history for these files, so you can just add/remove them.
Attachment #251125 -
Flags: review?(benjamin) → review+
Reporter | ||
Comment 2•18 years ago
|
||
Landed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•