366661 - Document that observers vetoing going offline MUST warn the user themselves

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: General, defect)

Description

[:Gijs (he/him)]

Steps to reproduce:
1. Click "Work Offline" in the File menu.
2. Use an observer, somewhere, to veto the "we'll be going offline now" notice, meaning we won't go offline.

Expected results:
User should be notified of not going offline even though they asked for it.

Actual results:
No user feedback.


I'm wondering though, popping up another dialog might be confusing - most observers will ask the user before deciding when they want to veto (Download Manager does this, ChatZilla will, etc.) This would mean you get at least two dialogs, one asking whether you want to go offline, and the next "ok, we didn't *really* go offline". Which seems odd to me.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> I'm wondering though, popping up another dialog might be confusing - most
> observers will ask the user before deciding when they want to veto (Download
> Manager does this, ChatZilla will, etc.) This would mean you get at least two
> dialogs, one asking whether you want to go offline, and the next "ok, we didn't
> *really* go offline". Which seems odd to me.

You're right, we can probably just depend on the canceling code to alert the user, though it'd be even better if we could have the observing code explicitly indicate that it did so, and fall back to doing it ourselves if it doesn't but still denies the request. That's probably not worth the trouble, I guess. Perhaps we should turn this into a documentation bug to ensure that observers of this topic know that it's their responsibility to notify the user.

Comment 2

[:Gijs (he/him)]

(In reply to comment #1)
> Perhaps we should turn this into a documentation bug to ensure that observers
> of this topic know that it's their responsibility to notify the user.


Sounds good to me.

Comment 3

[Nickolay_Ponomarev]

In the MDC component you're more likely to get noticed :)

Comment 4

[Eric Shepherd [:sheppy]]

Added a note to the description of the offline-requested event saying that you must notify the user if you decide to cancel the offline switch.