366831 - In <autocomplete.xml>, "Warning: reference to undefined property Components.classes[contractid]", when starting Browser.

Status: RESOLVED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a2pre) Gecko/20070111 SeaMonkey/1.5a] (nightly) (W2Ksp4)

{
Warning: reference to undefined property Components.classes[contractid]
Source File: chrome://global/content/autocomplete.xml
Line: 116
}

This line is blamed to
{
1.130	neil%parkwaycc.co.uk	2006-04-12 16:00	 	Bug 313331 autocomplete file names in xul filepicker r=bz sr=jag
}

Comment 1

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.9) Gecko/20061211 SeaMonkey/1.0.7] (release) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2pre) Gecko/20070112 SeaMonkey/1.1] (nightly) (W2Ksp4)

No bug.

Comment 2

[[e-mail]]

This happens on non-linux builds because they don't have file autocomplete.

jag: There seem to be two approaches
1) add an in check to see if a component exists, and optionally dump a helpful message for any developer trying to use autocomplete with that component
2) add an in check and an instanceof check and remove the try/catch

Comment 3

[jag (Peter Annema)]

I think I prefer 1. So would there then be two possible messages: "component doesn't exist" and "unable to create component"?

Also (though this probably belongs in a new bug), can we build file autocomplete on Mac so I can type file paths in the location bar and open location dialog?

Comment 4

[[e-mail]]

(In reply to comment #3)
>Also (though this probably belongs in a new bug), can we build file
>autocomplete on Mac so I can type file paths in the location bar and open
>location dialog?
Tricky; the current file autocomplete is built by the XUL filepicker...

Comment 5

[[e-mail]]

Attachment: Something like this?

Comment 6

[jag (Peter Annema)]

Comment on attachment 263245 [details] [diff] [review]
Something like this?

Seems fine to me

Comment 7

[[e-mail]]

Fix checked in.

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070501 SeaMonkey/1.5a] (nightly) (W2Ksp4)

V.Fixed, as reporter.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2088c6317f4c
JavaScript strict warning: reference to undefined property r+sr=jag