366880 - Column bugs

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: testcase

1) default column-gap is 0, the spec has been updated to make 1em the initial value.

2) The attached testcase shows that vertical margins screw up incremental reflow ... try resize the text in different directions.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: support -moz-column-gap:normal and make it the initial value

... as per latest columns draft.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 251612 [details] [diff] [review]
support -moz-column-gap:normal and make it the initial value

r+sr=dbaron

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Actually, could you also add support for eCSSUnit_Initial in the nsRuleNode.cpp changes?

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Er, never mind, since that's actually pretty ugly in the current architecture.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Checked in. The incremental reflow bug was filed as bug 367099.

Comment 6

[Boris Zbarsky [:bzbarsky]]

So I was wondering... in getComputedStyle do we want to compute to the length as in this patch, or the keyword "normal"?

In general, the actual computed style is "normal", but in some cases getComputedStyle returns used style...

Just need to know so I can merge the patch for bug 365932 to this change.

I'll admit I'm a little biased because "normal" is easier to do.  ;)

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm fine either way.