PSM displays wrong for frames named "content" or "left"

VERIFIED WORKSFORME

Status

()

Core
Layout: HTML Frames
P3
normal
VERIFIED WORKSFORME
19 years ago
16 years ago

People

(Reporter: John Unruh, Assigned: Dan M)

Tracking

Trunk
Future
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta2-][rtm-], URL)

(Reporter)

Description

19 years ago
1) Visit https://enigma.barclaycard.co.uk. Wait for full download.
2) Click on the lock icon.
What is expected: PSM would appear with relevant info.
What happens: PSM appears, but the relevant info is in a frame of the Barclay's 
website.
Build 2000042009. WinNT and Linux.

Comment 1

19 years ago
does this happen on any https url?
(Reporter)

Comment 2

19 years ago
I've only seen it on this particular URL
(Reporter)

Updated

19 years ago
Keywords: nsbeta2
Target Milestone: --- → M17

Comment 3

19 years ago
nsbeta2- unless the problem turns out to be more widespread
Whiteboard: [nsbeta2-]
(Reporter)

Comment 4

18 years ago
Reassigning to javi during dougt's absence for the next three weeks.
Assignee: dougt → javi

Comment 5

18 years ago
This is actually a bug in the DOM code which tends to get confused in certain 
cases where frames are used.  It'll fill in the wrong frame with content from a 
different window.  Please re-assign.
(Reporter)

Comment 6

18 years ago
Reassigning
Assignee: javi → alecf
Component: Security: Crypto → DOM Viewer

Comment 7

18 years ago
why is this assigned to me? this is a browser bug. reassigning to don
Assignee: alecf → don

Comment 8

18 years ago
needs owner
Target Milestone: M17 → M18

Comment 9

18 years ago
If this is a Frames or DOM problem, then why do I have it?

Over to Eric Pollmann for triaging ... 'cause I have no clue who should get
this.
Component: DOM Viewer → HTMLFrames
Target Milestone: M18 → ---

Comment 10

18 years ago
OK, let's REALLY re-assign it this time.
Assignee: don → pollmann
QA Contact: junruh → petersen

Comment 11

18 years ago
Reduced test case (does not require https):

-------- http://blueviper/frames/contentframe.html
<frameset cols="*,*">
 <frame name=content src="about:blank">
 <frame name=foo src="about:blank">
</frameset>
--------

The problem is that if there is a frame named "content" in the document, when 
PSM tries to update it's frame named "content", it updates the document's frame 
instead of it's own.

CC'ing danm - guru of frame name resolution  :)

Comment 12

18 years ago
This means that if any page on the web has a frame named "content" or a frame 
named "left" (or heaven forbid both!), chunks of PSM will display in the 
brwoser frame by that name and not in the dialog as they should.  I think that 
this could actually be quite common...  Re-nominating for beta2 with this new 
information.

(There might also be a problem if the frame is named "top" but I've not been 
able to verify one yet)
Status: NEW → ASSIGNED
Summary: Weird PSM display behavior → PSM displays wrong for frames named "content" or "left"
Whiteboard: [nsbeta2-]
(Assignee)

Comment 13

18 years ago
The frame-named-content-collision problem was fixed, albeit in a rather cheesy 
way, on June 21st (see bug 33650). Does that kill this bug, too?

Comment 14

18 years ago
This bug is present with today's build.

I'm pretty sure this is a separate problem - PSM has a frame named "content" in 
it, and a frame named "left".  If you click on the Lock icon, and the page you 
are viewing in the browser has either a frame named "content" or a frame named 
"left", the frames in the page you are viewing in the browser will be updated, 
instead of the frames in the PSM dialog.  It seems like the search for the named 
frame is not starting in the right window or something like that???

Comment 15

18 years ago
That said, PSM could also use the cheese fix and rename these frame to 
_psm_content, _psm_left, and _psm_top.  ;)

Comment 16

18 years ago
Handing off to Dan.  Per our conversation - it seems like the problem may be a 
failure to search *our* window for the named frame before defering to the 
windows mediator and iterating through all windows looking for the named frame.  
Let me know if I can help!
Assignee: pollmann → danm
Status: ASSIGNED → NEW

Updated

18 years ago
Whiteboard: [nsbeta2-]

Comment 17

18 years ago
Putting on [nsbeta2-] radar. Not critical to beta2. 
(Assignee)

Comment 18

18 years ago
  This bug seems like a symptom of our incorrect search order when looking for 
windows to open. It'll cause edge-case problems with certain rare bits of JS, 
like in our PSM window. Hmmmm. Borderline. But marking "future" because of 
impending release time constraints.
Target Milestone: --- → Future
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 19

18 years ago
This now only happens when opening the Security manager from the Tasks menu.
Keywords: rtm
(Reporter)

Comment 20

18 years ago
*** Bug 57334 has been marked as a duplicate of this bug. ***

Comment 21

18 years ago
Hmm, this got nominated for rtm at the last minute, but the last comment implies
a workaround, so rtm-
Whiteboard: [nsbeta2-] → [nsbeta2-][rtm-]
(Reporter)

Comment 22

18 years ago
*** Bug 63255 has been marked as a duplicate of this bug. ***
(Reporter)

Comment 23

18 years ago
*** Bug 63255 has been marked as a duplicate of this bug. ***

Comment 24

18 years ago
This also happens when there is an open pop-up window.
For example, goto http://www.cnn.com and vote in the "Quick vote" to have a pop
up window.
If the pop-up window remains open, PSM displays actual info in that pop-up
window, and the menu tabs in its own pop-up window.
Is this an independent bug?

Comment 25

18 years ago
The cnn popuppoll window contains three frames named "top", "content" and
"back".  It is undoubtedly the window named "content" that is causing the
problem with PSM, meaning that that is exactly the same as this problem, not a
separate issue.

FWIW, when I had the popup window up, and clicked on the lock in *another*
window, nothing bad happened.  ???

Comment 26

18 years ago
QA Contact update
QA Contact: petersen → amar

Updated

17 years ago
Depends on: 113103

Updated

17 years ago
No longer depends on: 113103

Comment 27

17 years ago
I think this bug was fixed when PSM was re-written as I no longer the problem.
(Reporter)

Comment 28

17 years ago
Marking worksforme. PSM is totally different now, plus the page no longer 
exists.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → WORKSFORME
(Reporter)

Comment 29

16 years ago
Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.