36698 - PSM displays wrong for frames named "content" or "left"

Status: VERIFIED WORKSFORME

Description

[John Unruh]

1) Visit https://enigma.barclaycard.co.uk. Wait for full download.
2) Click on the lock icon.
What is expected: PSM would appear with relevant info.
What happens: PSM appears, but the relevant info is in a frame of the Barclay's 
website.
Build 2000042009. WinNT and Linux.

Comment 1

[Doug Turner (:dougt)]

does this happen on any https url?

Comment 2

[John Unruh]

I've only seen it on this particular URL

Comment 3

[Phil Peterson]

nsbeta2- unless the problem turns out to be more widespread

Comment 4

[John Unruh]

Reassigning to javi during dougt's absence for the next three weeks.

Comment 5

[Javier Delgadillo]

This is actually a bug in the DOM code which tends to get confused in certain 
cases where frames are used.  It'll fill in the wrong frame with content from a 
different window.  Please re-assign.

Comment 6

[John Unruh]

Reassigning

Comment 7

[Alec Flett]

why is this assigned to me? this is a browser bug. reassigning to don

Comment 8

[Chris McAfee]

needs owner

Comment 9

[don]

If this is a Frames or DOM problem, then why do I have it?

Over to Eric Pollmann for triaging ... 'cause I have no clue who should get
this.

Comment 10

[don]

OK, let's REALLY re-assign it this time.

Comment 11

[Eric Pollmann]

Reduced test case (does not require https):

-------- http://blueviper/frames/contentframe.html
<frameset cols="*,*">
 <frame name=content src="about:blank">
 <frame name=foo src="about:blank">
</frameset>
--------

The problem is that if there is a frame named "content" in the document, when 
PSM tries to update it's frame named "content", it updates the document's frame 
instead of it's own.

CC'ing danm - guru of frame name resolution  :)

Comment 12

[Eric Pollmann]

This means that if any page on the web has a frame named "content" or a frame 
named "left" (or heaven forbid both!), chunks of PSM will display in the 
brwoser frame by that name and not in the dialog as they should.  I think that 
this could actually be quite common...  Re-nominating for beta2 with this new 
information.

(There might also be a problem if the frame is named "top" but I've not been 
able to verify one yet)

Comment 13

[Dan M]

The frame-named-content-collision problem was fixed, albeit in a rather cheesy 
way, on June 21st (see bug 33650). Does that kill this bug, too?

Comment 14

[Eric Pollmann]

This bug is present with today's build.

I'm pretty sure this is a separate problem - PSM has a frame named "content" in 
it, and a frame named "left".  If you click on the Lock icon, and the page you 
are viewing in the browser has either a frame named "content" or a frame named 
"left", the frames in the page you are viewing in the browser will be updated, 
instead of the frames in the PSM dialog.  It seems like the search for the named 
frame is not starting in the right window or something like that???

Comment 15

[Eric Pollmann]

That said, PSM could also use the cheese fix and rename these frame to 
_psm_content, _psm_left, and _psm_top.  ;)

Comment 16

[Eric Pollmann]

Handing off to Dan.  Per our conversation - it seems like the problem may be a 
failure to search *our* window for the named frame before defering to the 
windows mediator and iterating through all windows looking for the named frame.  
Let me know if I can help!

Comment 17

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2. 

Comment 18

[Dan M]

  This bug seems like a symptom of our incorrect search order when looking for 
windows to open. It'll cause edge-case problems with certain rare bits of JS, 
like in our PSM window. Hmmmm. Borderline. But marking "future" because of 
impending release time constraints.

Comment 19

[John Unruh]

This now only happens when opening the Security manager from the Tasks menu.

Comment 20

[John Unruh]

*** Bug 57334 has been marked as a duplicate of this bug. ***

Comment 21

[Peter Trudelle]

Hmm, this got nominated for rtm at the last minute, but the last comment implies
a workaround, so rtm-

Comment 22

[John Unruh]

*** Bug 63255 has been marked as a duplicate of this bug. ***

Comment 23

[John Unruh]

*** Bug 63255 has been marked as a duplicate of this bug. ***

Comment 24

[hirata masakazu]

This also happens when there is an open pop-up window.
For example, goto http://www.cnn.com and vote in the "Quick vote" to have a pop
up window.
If the pop-up window remains open, PSM displays actual info in that pop-up
window, and the menu tabs in its own pop-up window.
Is this an independent bug?

Comment 25

[Eric Pollmann]

The cnn popuppoll window contains three frames named "top", "content" and
"back".  It is undoubtedly the window named "content" that is causing the
problem with PSM, meaning that that is exactly the same as this problem, not a
separate issue.

FWIW, when I had the popup window up, and clicked on the lock in *another*
window, nothing bad happened.  ???

Comment 26

[Amarendra Hanumanula]

QA Contact update

Comment 27

[Ian Neal]

I think this bug was fixed when PSM was re-written as I no longer the problem.

Comment 28

[John Unruh]

Marking worksforme. PSM is totally different now, plus the page no longer 
exists.

Comment 29

[John Unruh]

Verified.