367015 - Crash [@ nsBidiPresUtils::RepositionInlineFrames]

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Loading this testcase makes Firefox trunk crash [@ nsBidiPresUtils::RepositionInlineFrames].

This regressed between 2007-01-11 and 2007-01-14.  Could it have been caused by the patch in bug 364839?

Comment 1

[Uri Bernstein]

> This regressed between 2007-01-11 and 2007-01-14.  Could it have been caused by
> the patch in bug 364839?
> 

Yes, it probably was. I'll look at it later today.

Comment 2

[Uri Bernstein]

Attachment: patch

Deal with empty line frames (although I'm not sure why there should be an empty line frame in this case, or ever).

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 251543 [details] [diff] [review]
patch

Looks reasonable.  r+sr=bzbarsky.

The reason there's an empty line frame is that :first-line is a mess and we get an empty line frame if the first child is a block... ;)

Comment 4

[Uri Bernstein]

Checked in:

Checking in mozilla/layout/base/nsBidiPresUtils.cpp;
/cvsroot/mozilla/layout/base/nsBidiPresUtils.cpp,v  <--  nsBidiPresUtils.cpp
new revision: 1.90; previous revision: 1.89
done

Comment 5

[Jesse Ruderman]

Crashtest checked in.