367081 - NSResponder+Utils is never used

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[froodian (Ian Leue)]

Attachment: Patch

We import NSResponder+Utils in MainController and NSMenu+Utils, but neither of its two methods are ever used.  If there's no compelling reason not to, it seems we can/should remove the NSResponder extension entirely.

The included patch will require project patches to remove references to the files, and cvs removing on checkin.

Comment 1

[froodian (Ian Leue)]

Simon, is there any particular reason to keep the NSResponder extension?  When you checked it in, you said

"New category on NSResponder to find the responder for a given action, and find an item of a particular class in the responder chain.  Add method on NSMenu category to enable or disable all items (potentially recursing into submenus)."

Comment 2

[Simon Fraser [no longer active]]

Feel free to rip it out.

Comment 3

[Chris Lawson (gone)]

Comment on attachment 251598 [details] [diff] [review]
Patch

r=me, then. :)

Comment 4

[Stuart Morgan]

Comment on attachment 251598 [details] [diff] [review]
Patch

sr=smorgan (but there's probably not much point in landing this until there's a project patch)

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: trunk project patch

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: branch project patch

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

By some miracle of $DEITY, the project patches here still apply.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 252656 [details] [diff] [review]
trunk project patch

...not anymore

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Combined trunk patch, as landed

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Combined branch patch, as landed

This branch patch also "backs out" a lastKnownFileType/explicitFileType change that kreeger inadvertently added in rev 1.2.2.9 / bug 282002, so that line is now in sync both within the branch project's two targets and with the trunk project.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the trunk and MOZILLA_1_8_BRANCH.