Make mozconfig-find space-safe (e.g. spaces in $HOME)

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: bsmedberg, Assigned: bsmedberg)

Tracking

({fixed1.8.0.10, fixed1.8.1.2})

Trunk
x86
All
fixed1.8.0.10, fixed1.8.1.2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
Created attachment 251639 [details] [diff] [review]
Honor mozconfig with spaces, rev. 1

If your $HOME is /c/Documents and Settings/Benjamin Smedberg mozconfig-find doesn't find a .mozconfig in it.
Attachment #251639 - Flags: review?(dbaron)
Comment on attachment 251639 [details] [diff] [review]
Honor mozconfig with spaces, rev. 1

r=dbaron
Attachment #251639 - Flags: review?(dbaron) → review+
(Assignee)

Comment 2

11 years ago
Fixed on trunk. I'd like to get this on the active branches as well.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

11 years ago
Comment on attachment 251639 [details] [diff] [review]
Honor mozconfig with spaces, rev. 1

As a build-config change this is very low-risk.
Attachment #251639 - Flags: approval1.8.1.2?
Attachment #251639 - Flags: approval1.8.0.10?

Comment 4

11 years ago
Comment on attachment 251639 [details] [diff] [review]
Honor mozconfig with spaces, rev. 1

Approved for both branches, a=jay for drivers.
Attachment #251639 - Flags: approval1.8.1.2?
Attachment #251639 - Flags: approval1.8.1.2+
Attachment #251639 - Flags: approval1.8.0.10?
Attachment #251639 - Flags: approval1.8.0.10+
(Assignee)

Comment 5

11 years ago
Fixed on MOZILLA_1_8_BRANCH and MOZILLA_1_8_0_BRANCH
Keywords: fixed1.8.0.10, fixed1.8.1.2
You need to log in before you can comment on or make changes to this bug.