367153 - Event text not readable in calendar view during inline editing (due to unselection)

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a2pre) Gecko/20070116 Calendar/0.6a1

Event text not readable in calendar view during inline editing if a dark background color is selected for the calendar. This seems to be caused by the fact the the event gets unselected when inline editing starts.

Steps to Reproduce:
1. Go to Calendars tab and select a dark color for this calendar
2. Create some dummy events for this calendar
3. Click event in main calendar view to select it
4. Click event in main calendar view to start inline editing
5. Move cursor and type some text

Actual Results:
Event box is displays black text on dark background.

Expected Results:
Either text is shown with readable color or the event doesn't get unselected when inline editing starts.

Regression range:
  Works in Sunbird/0.4a1 (2007-01-10-03)
  Fails in Sunbird/0.4a1 (2007-01-10-08)
  --> Bug 361211

Previous behaviour:
  Event, normal:         dark background + white text
  Event, selected:       orange background + black text
  Event, inline editing: orange background + black text

Current behaviour:
  Event, normal:         dark background + white text
  Event, selected:       orange background + black text
  Event, inline editing: dark background + black text

Comment 2

[Christian Jansen]

Requesting wanted‑calendar0.8 since this is a very annoying and prominent bug.

Comment 3

[Simon Paquet [:sipaq]]

Not going to happen for 0.8.

Comment 4

[Christian Jansen]

Second try ;-) Requesting wanted‑calendar 0.9 since this is a very annoying and prominent bug.

Comment 5

[Berend Cornelius]

Attachment: patch v. #1

textcolor was not inherited from the parent

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 323064 [details] [diff] [review]
patch v. #1

r=philipp

Comment 7

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH

->FIXED

Comment 8

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.15pre) Gecko/2008053020 Calendar/0.9pre

Error still exists in Multiweek and Month view. In Day and week view it works now.

Comment 9

[Berend Cornelius]

Attachment: patch v. #2

I aligned the code of both bindings and decided to set the color inline similar to the background-color

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 323385 [details] [diff] [review]
patch v. #2

I'd prefer to have both the background color and the color in a css style rule, and not inline. That makes the xul code more readable.

Comment 11

[Berend Cornelius]

Attachment: patch v. #3

I outsourced the css rule as Philipp objected

Comment 12

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 323527 [details] [diff] [review]
patch v. #3

r=philipp

Comment 13

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH
->FIXED

Comment 14

[Andreas Treumann]

checked in lightning 2008081218 and sunbird 20080812 -> VERIFIED