367226 - Option to change JS_THREADED_INTERP without changing the code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Igor Bukanov]

Currently JS_THREADED_INTERP macro in jsinterp.c is defined as:

#if JS_VERSION >= 160 && (                                                    \
    __GNUC__ >= 3 ||                                                          \
    (__IBMC__ >= 700 && defined __IBM_COMPUTED_GOTO) ||                       \
    __SUNPRO_C >= 0x570)
# define JS_THREADED_INTERP 1
#else
# undef JS_THREADED_INTERP
#endif

That does not allow to redefine the macro when invoking the compiler without changing the code. It would be nice to permit that for debugging/testing.

Comment 1

[Igor Bukanov]

Attachment: Implementation v1 (quilt diff)

The patch defines JS_THREADED_INTERP only if it is not already defined and changes the checks for the macro from if defined JS_THREADED_INTERP to if JS_THREADED_INTERP.

Comment 2

[Igor Bukanov]

Attachment: Implementation v1 (cvs diff)

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 252028 [details] [diff] [review]
 Implementation v1 (cvs diff)

Looks good.

/be

Comment 4

[Igor Bukanov]

I committed the patch from comment 2 to the trunk:

Checking in jsinterp.c;
/cvsroot/mozilla/js/src/jsinterp.c,v  <--  jsinterp.c
new revision: 3.325; previous revision: 3.324
done