367275 - download manager file folder icon is black

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[aja+bugzilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070117 Minefield/3.0a2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070117 Minefield/3.0a2pre

the file folder icon is showing up black, instead of its normal color

Reproducible: Always

Steps to Reproduce:
1. install a recent minefield hourly (e.g. 2007011711)
2. download a file
3. note color of the file folder icon in download manager
Actual Results:  
black file folder icon in download manager

Expected Results:  
normally-colored file folder icon in download manager

likely a regression from bug 360000

Comment 1

[aja+bugzilla]

FYI: Win XP/SP2's "Display" setting "Color quality" is set to "32-bit".

Comment 2

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070117 Minefield/3.0a2pre ID:2007011711 [cairo]
confirmed

Comment 3

[Alfred Kayser]

Attachment: Patch to fix 32-bit ico's with out transparency

Note, this is not a CVS patch (today I don't have access to CVS).
So may be some else can do make it into a CVS patch and apply.

The bug was caused by premultiplying also the 32-bit pixels with the ICO has no transparancy set.

Comment 4

[Ale Mand]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070117 Minefield/3.0a2pre

Confirmed

Comment 5

[Alfred Kayser]

Attachment: V2: Really fix the issue in the right way

Only do premultiplication when the 32bit ico really has alpha.
We can only know for sure that the alpha channel has really alpha data after scanning the whole image. 

So, this fix makes it so that SetPixel doesn't do premultiplication,
but SetImageData does this when mHaveAlpha is true.
Note, the 'premultiplication' function has been copied from libpixman.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Thanks for resetting the flags on that attachment, because it reminded me that I included the v2 patch with my most recent build to test that patch and then proceeded to completely forget that I'd done so.

Anyway, the v2 patch works fine for win32. The icons in the download manager look nice and normal again.

Comment 7

[Nickolay_Ponomarev]

Checked in:
mozilla/modules/libpr0n/decoders/bmp/nsBMPDecoder.h     1.24
mozilla/modules/libpr0n/decoders/bmp/nsICODecoder.cpp   1.41

Comment 8

[aja+bugzilla]

Looking good.