36730 - [Feature] Popup menu in Autocomplete widget not fully implemented

Status: RESOLVED FIXED

(Core :: XBL, defect, P3)

Description

[Jean-Francois Ducarroz]

The autocomplete widget needs to show a popup menu with all the matches. The 
known remaining problems that prevent me to activate it are:

1) popup menu still all key events, therefore, when the popup menu is shown, you 
must press <esc> in order to continue typing in the edit field. This is covered 
by bug 35690. The solution is to let the editfield take care of the menu 
navigation.

2) Need to select default menu item (in case of mailnews, it's normally the 
second one).

3) Need to support a comment in the menu item. Typically, the browser would want 
to be able to put the URL + the page title in the menu item, when selected, only 
the url goes in the edit field.

4) Need to replace current editfield content with value of the menu item 
selected.

Comment 1

[Jean-Francois Ducarroz]

accepting

Comment 2

[Jean-Francois Ducarroz]

I have another dependency on bug 38459

Comment 3

[Jean-Francois Ducarroz]

The implementation of the popup menu is almost done. But as I still have 
bad issues (see dependencies), I don't think so it's the right time to activate 
it. Therefore, I have added a new atrtribute to the autocomplete widget that let 
you turn off the popup menu: displayMenu="false". If the attribute displayMenu 
isn't defined, the popup will be shown.

Event when the popup menu is not displayed, the user can still navigate through 
the different result using the up and down arrow key.

Comment 4

[Radha on family leave (not reading bugmail)]

Is the feature of navigating  multiple results thro' up and down key enabled 
*only* if popup menu is disabled? Few days ago when I tried to use the up & down 
key, it didn't take thro' the  results. Also Is the feature disableMenu="false" 
turned on?

Comment 5

[Jean-Francois Ducarroz]

>Is the feature of navigating  multiple results thro' up and down key enabled *only* if popup menu is disabled? 
No, it's alway enable

>Few days ago when I tried to use the up & down key, it didn't take thro' the  results.
Right, it's working only since last night

>Also Is the feature disableMenu="false" turned on?
Yes, look at message compose addressing widget, it already uses it. But in you case, you should try to display the 
menu first, it might be working enough well for you?

Comment 6

[Jean-Francois Ducarroz]

Popup menu has been activated on MsgCompose as It's now working enough well.
Fix and checked in.

Comment 7

[Radha on family leave (not reading bugmail)]

ducarroz, when I enabled autocomplete in the urlbar yesterday, I noticed that 
the menu came up, but wasn't sticking to the urlbar. It was standing out 
separately. is that a known bug. Does it happen only with urlbar? Is that some 
kind of style problem? Whom s'd I bug?  Thanks.

Comment 8

[Jean-Francois Ducarroz]

It's a now bug that pinkerton is looking at (but we didn't file a bug). 
Apparently the popup menu location is offset by the same amount of pixel of the 
location of the edit field. i 'll file a bug...