367459 - jar: directory listings incorrectly list all files, including files in subdirectories

Status: VERIFIED FIXED

(Core :: Networking: JAR, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Current trunk build.

STEPS TO REPRODUCE:

1) Pick any ZIP file with subdirectories with URL "URL".
2) Load jar:URL!/

I'll attach a testcase and point the URL field of the bug to it.

EXPECTED RESULTS: See a listing of the _root_ directories in the ZIP file.

ACTUAL RESULTS: See a listing of all files in the ZIP, with full paths.

NOTES:  As soon as I go down one directory, things look ok.

This regressed when bug 337561 was checked in.

Now that I've actually updated to a current trunk build, this has been causing me a _lot_ of pain recently -- I often have to browse testcase ZIPs.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: ZIP file

Comment 2

[Boris Zbarsky [:bzbarsky]]

Note that I think we should back out bug 337561 if we don't get traction on this for 1.9...

Comment 3

[Alfred Kayser]

Attachment: Patch to fix the 'root' filtering

The fix is luckely very simple.
All one needs to do is to remove the if(!*aDir) optimisation in constructing the filter for the item selection for the jar directory display.

(note, it would be nice if both things could be possible: list only root items, and list all items, but that would require an extension to the jar: URI protocol).

Anyway this patch is not really CVS (I have today no CVS access), but it is simple enough to be applied.

Comment 4

[Benjamin Smedberg]

Could someone create a unit test for this?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 252031 [details] [diff] [review]
Patch to fix the 'root' filtering

Looks reasonable.

Thanks for the patch!

Comment 6

[Boris Zbarsky [:bzbarsky]]

Er... Except that patch doesn't apply to a current tree.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Attachment: CVS diff of attachment 252031 off current trunk

This is Alfred's patch, but created as a proper cvs diff off the trunk. I've also confirmed that Firefox builds OK with it applied using VC8.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Awesome.  Checked in.