Closed
Bug 367464
Opened 19 years ago
Closed 18 years ago
Remove chimera.search_page and associated code/strings
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.6
People
(Reporter: alqahira, Assigned: markus)
References
()
Details
(Keywords: fixed1.8.1.12)
Attachments
(1 file)
|
3.13 KB,
patch
|
mark
:
review+
|
Details | Diff | Splinter Review |
chimera.search_page hasn't done anything since, well, who knows. There's a glob of code for it sitting around in PreferenceManager, as well as a string in WebsiteDefaults.strings.
They both should be axed.
|
Reporter | |
Updated•18 years ago
|
Whiteboard: [good first bug]
|
Assignee | |
Comment 1•18 years ago
|
||
Adding patch that removes the searchPage method, which isn't used anywhere in code or in nibs.
Attachment #293385 -
Flags: review?(stuart.morgan)
|
|
Assignee | |
Updated•18 years ago
|
Attachment #293385 -
Flags: review?(mark)
|
||
Updated•18 years ago
|
Attachment #293385 -
Flags: review?(mark) → review+
|
|
||
Comment 2•18 years ago
|
||
Comment on attachment 293385 [details] [diff] [review]
Remove the searchPage method
One review's enough for this.
Attachment #293385 -
Flags: review?(stuart.morgan)
|
|
||
Updated•18 years ago
|
Whiteboard: [good first bug] → [needs checkin]
|
|
||
Updated•18 years ago
|
Assignee: nobody → markus.magnuson
Target Milestone: --- → Camino1.6
|
|
Reporter | |
Comment 3•18 years ago
|
||
Landed on the trunk and MOZILLA_1_8_BRANCH. Thanks for the patch, Markus!
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1.12
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in
before you can comment on or make changes to this bug.
Description
•